[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1545: MINIFICPP-55 Implement test coverage report generation

["szaszm (via GitHub)" <gi...@apache.org>]

szaszm commented on code in PR #1545:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1545#discussion_r1231019414


##########
cmake/CodeCoverage.cmake:
##########
@@ -0,0 +1,748 @@
+# Copyright (c) 2012 - 2017, Lars Bilke
+# All rights reserved.
+#

Review Comment:
   We need LICENSE+NOTICE changes for this. Please check which license is below, and add its name to LICENSE as well.



##########
.github/workflows/ci.yml:
##########
@@ -156,6 +159,14 @@ jobs:
         run: cd build && make shellcheck
       - id: flake8_check
         run: cd build && make flake8
+      - id: coverage

Review Comment:
   The condition seems no different from all of our typical runs, so it may be better to just omit it. That is if the build time overhead is low enough. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org