You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/06/24 16:30:34 UTC

[GitHub] [hadoop] ahmarsuhail opened a new pull request, #4499: Fixes typos in Delegation Tokens documentation.

ahmarsuhail opened a new pull request, #4499:
URL: https://github.com/apache/hadoop/pull/4499

   ### Description of PR
   
   Noticed some typos while reading through the documentation, this PR fixes those.
   
   ### How was this patch tested?
   
   Not required
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #4499: HADOOP-18320. Fixes typos in Delegation Tokens documentation.

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on PR #4499:
URL: https://github.com/apache/hadoop/pull/4499#issuecomment-1171317710

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 50s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  |
   | +0 :ok: |  markdownlint  |   0m  0s |  |  markdownlint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain any @author tags.  |
   |||| _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  39m 46s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   0m 54s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  63m 13s |  |  branch has no errors when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 40s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  1s |  |  The patch has no blanks issues.  |
   | +1 :green_heart: |  mvnsite  |   0m 41s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  25m 12s |  |  patch has no errors when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 44s |  |  The patch does not generate ASF License warnings.  |
   |  |   |  92m 11s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4499/2/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/4499 |
   | Optional Tests | dupname asflicense mvnsite codespell detsecrets markdownlint |
   | uname | Linux cc35919d3ee5 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 34c0e34d8152ce929756b32fee98984b8d9a22d0 |
   | Max. process+thread count | 607 (vs. ulimit of 5500) |
   | modules | C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws |
   | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4499/2/console |
   | versions | git=2.25.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] ahmarsuhail commented on a diff in pull request #4499: HADOOP-18320. Fixes typos in Delegation Tokens documentation.

Posted by GitBox <gi...@apache.org>.
ahmarsuhail commented on code in PR #4499:
URL: https://github.com/apache/hadoop/pull/4499#discussion_r1062386144


##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md:
##########
@@ -353,10 +352,10 @@ it is authenticated with; the role token binding will fail.
 
 When the AWS credentials supplied to the Session Delegation Token binding
 through `fs.s3a.aws.credentials.provider` are themselves a set of

Review Comment:
   this seems fine to me as is. Maybe removing the themselves entirely would help, so it becomes "through `fs.s3a.aws.credentials.provider` are a set of", but personally feel it's clearer as is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] dannycjones commented on a diff in pull request #4499: Fixes typos in Delegation Tokens documentation.

Posted by GitBox <gi...@apache.org>.
dannycjones commented on code in PR #4499:
URL: https://github.com/apache/hadoop/pull/4499#discussion_r909585560


##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md:
##########
@@ -184,18 +184,18 @@ running in secure mode; somewhere where the `core-site.xml` configuration
 sets `hadoop.security.authentication` to to `kerberos` or another valid

Review Comment:
   duplicate 'to' in this line
   
   ```suggestion
   sets `hadoop.security.authentication` to `kerberos` or another valid
   ```



##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md:
##########
@@ -413,7 +413,7 @@ The XML settings needed to enable session tokens are:
 ```
 
 A JSON role policy for the role/session will automatically be generated which will
-consist of
+consist of:

Review Comment:
   Add a new line below this too, otherwise markdown won't format it properly. (It is broken before your change)
   
   ```suggestion
   consist of:
   
   ```



##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md:
##########
@@ -108,7 +108,7 @@ password-protected data opaque to clients; they contain the secrets needed
 to access the relevant S3 buckets and associated services.
 
 They are obtained by requesting a delegation token from the S3A filesystem client.
-Issued token mey be included in job submissions, passed to running applications,
+Issued tokens may be included in job submissions, passed to running applications,
 etc. This token is specific to an individual bucket; all buckets which a client
 wishes to work with must have a separate delegation token issued.

Review Comment:
   I find this confusing in the context of delegated role tokens, where the token is _literally_ specific to an individual bucket.
   
   Can we make this clearer while we are editing this paragraph?
   
   ```suggestion
   Issued tokens may be included in job submissions, passed to running applications,
   etc.
   Delegation tokens are specific to an S3A filesystem.
   Each filesystem a client wishes to work with must have a separate delegation token issued,
   regardless of the delegation token variant.
   ```
   
   Is it correct to describe them specific to a filesystem rather than the bucket?



##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md:
##########
@@ -37,7 +37,7 @@ the S3A client from the AWS STS service. They have a limited duration
 so restrict how long an application can access AWS on behalf of a user.
 Clients with this token have the full permissions of the user.
 
-*Role Delegation Tokens:* These contain an "STS Session Token" requested by by the
+*Role Delegation Tokens:* These contain an "STS Session Token" requested by the
 STS "Assume Role" API, so grant the caller to interact with S3 as specific AWS
 role, *with permissions restricted to purely accessing that specific S3 bucket*.

Review Comment:
   Maybe we can make it a bit clearer. It utilises a feature of STS allowing you to scope-down permissions which you can pass on.
   
   ```suggestion
   *Role Delegation Tokens:* These contain an "STS Session Token" requested by the
   STS "Assume Role" API, granting the caller permission to interact with S3 using a specific IAM
   role, *with permissions restricted to accessing a specific S3 bucket*.
   ```



##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md:
##########
@@ -55,13 +55,13 @@ see [S3A Delegation Token Architecture](delegation_token_architecture.html).
 
 ## <a name="background"></a> Background: Hadoop Delegation Tokens.
 
-A Hadoop Delegation Token are is a byte array of data which is submitted to
-a Hadoop services as proof that the caller has the permissions to perform
+A Hadoop Delegation Token is a byte array of data which is submitted to
+Hadoop services as proof that the caller has the permissions to perform
 the operation which it is requesting —
-and which can be passed between applications to *delegate* those permission.
+and which can be passed between applications to *delegate* those permissions.
 
-Tokens are opaque to clients, clients who simply get a byte array
-of data which they must to provide to a service when required.
+Tokens are opaque to clients. Clients simply get a byte array
+of data which they must provide to a service when required.

Review Comment:
   Since we are touching this line, add a line break before "Clients simply" to keep sentence diffs independent in future.
   
   



##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md:
##########
@@ -184,18 +184,18 @@ running in secure mode; somewhere where the `core-site.xml` configuration
 sets `hadoop.security.authentication` to to `kerberos` or another valid
 authentication mechanism.
 
-* Without enabling security at this level, delegation tokens will not
+*Without enabling security at this level, delegation tokens will not
 be collected.*
 
-Once Kerberos enabled, the process for acquiring tokens is as follows:
+Once Kerberos is enabled, the process for acquiring tokens is as follows:
 
 1. Enable Delegation token support by setting `fs.s3a.delegation.token.binding`
 to the classname of the token binding to use.
 to use.

Review Comment:
   drop line 194?
   
   ```suggestion
   1. Enable Delegation token support by setting `fs.s3a.delegation.token.binding`
   to the classname of the token binding to use.
   ```



##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md:
##########
@@ -141,10 +141,10 @@ for specifics details on the (current) token lifespan.
 
 ### <a name="role-tokens"></a> S3A Role Delegation Tokens
 
-A Role Delegation Tokens is created by asking the AWS
+A Role Delegation Token is created by asking the AWS
 [Security Token Service](http://docs.aws.amazon.com/STS/latest/APIReference/Welcome.html)
-for set of "Assumed Role" credentials, with a AWS account specific role for a limited duration..
-This role is restricted to only grant access the S3 bucket and all KMS keys,
+for set of "Assumed Role" credentials, with an AWS account specific role for a limited duration.
+This role is restricted to only grant access the S3 bucket and all KMS keys.

Review Comment:
   We can be more explicit.
   
   ```suggestion
   The resulting session credentials are restricted to grant access to all KMS keys, and to the specific S3 bucket.
   ```



##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md:
##########
@@ -141,10 +141,10 @@ for specifics details on the (current) token lifespan.
 
 ### <a name="role-tokens"></a> S3A Role Delegation Tokens
 
-A Role Delegation Tokens is created by asking the AWS
+A Role Delegation Token is created by asking the AWS
 [Security Token Service](http://docs.aws.amazon.com/STS/latest/APIReference/Welcome.html)
-for set of "Assumed Role" credentials, with a AWS account specific role for a limited duration..
-This role is restricted to only grant access the S3 bucket and all KMS keys,
+for set of "Assumed Role" credentials, with an AWS account specific role for a limited duration.

Review Comment:
   Perhaps we can simplify.
   
   ```suggestion
   for a set of "Assumed Role" session credentials with a limited lifetime, belonging to a given IAM Role.
   ```



##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md:
##########
@@ -465,7 +465,7 @@ that of the role itself: 1h by default, though this can be changed to
 12h [In the IAM Console](https://console.aws.amazon.com/iam/home#/roles),
 or from the AWS CLI.
 
-*Without increasing the duration of role, one hour is the maximum value;
+Without increasing the duration of role, one hour is the maximum value;

Review Comment:
   ```suggestion
   Without increasing the duration of the role, one hour is the maximum value;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #4499: Fixes typos in Delegation Tokens documentation.

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on PR #4499:
URL: https://github.com/apache/hadoop/pull/4499#issuecomment-1165810079

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   1m  7s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  |
   | +0 :ok: |  markdownlint  |   0m  0s |  |  markdownlint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain any @author tags.  |
   |||| _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  41m  3s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   0m 54s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  64m 19s |  |  branch has no errors when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 35s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks issues.  |
   | +1 :green_heart: |  mvnsite  |   0m 38s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  22m 45s |  |  patch has no errors when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 43s |  |  The patch does not generate ASF License warnings.  |
   |  |   |  91m 24s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4499/1/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/4499 |
   | Optional Tests | dupname asflicense mvnsite codespell detsecrets markdownlint |
   | uname | Linux c7ba420d0b17 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 86ef9d01dde1d44ad674d98ca8440a2fdfc5047c |
   | Max. process+thread count | 607 (vs. ulimit of 5500) |
   | modules | C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws |
   | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4499/1/console |
   | versions | git=2.25.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] mukund-thakur merged pull request #4499: HADOOP-18320. Fixes typos in Delegation Tokens documentation.

Posted by GitBox <gi...@apache.org>.
mukund-thakur merged PR #4499:
URL: https://github.com/apache/hadoop/pull/4499


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #4499: HADOOP-18320. Fixes typos in Delegation Tokens documentation.

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on PR #4499:
URL: https://github.com/apache/hadoop/pull/4499#issuecomment-1372200195

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 48s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  |
   | +0 :ok: |  markdownlint  |   0m  0s |  |  markdownlint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain any @author tags.  |
   |||| _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  41m 17s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   0m 41s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  64m 27s |  |  branch has no errors when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 30s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks issues.  |
   | +1 :green_heart: |  mvnsite  |   0m 32s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  22m 48s |  |  patch has no errors when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 34s |  |  The patch does not generate ASF License warnings.  |
   |  |   |  90m 34s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4499/3/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/4499 |
   | Optional Tests | dupname asflicense mvnsite codespell detsecrets markdownlint |
   | uname | Linux c0b8666f4e9e 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 736cedb4adc37822ef2f1ece48e4e4f4cca0d8c0 |
   | Max. process+thread count | 568 (vs. ulimit of 5500) |
   | modules | C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws |
   | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4499/3/console |
   | versions | git=2.25.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] dannycjones commented on a diff in pull request #4499: HADOOP-18320. Fixes typos in Delegation Tokens documentation.

Posted by GitBox <gi...@apache.org>.
dannycjones commented on code in PR #4499:
URL: https://github.com/apache/hadoop/pull/4499#discussion_r911038139


##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md:
##########
@@ -108,7 +108,7 @@ password-protected data opaque to clients; they contain the secrets needed
 to access the relevant S3 buckets and associated services.
 
 They are obtained by requesting a delegation token from the S3A filesystem client.
-Issued token mey be included in job submissions, passed to running applications,
+Issued tokens may be included in job submissions, passed to running applications,
 etc. This token is specific to an individual bucket; all buckets which a client
 wishes to work with must have a separate delegation token issued.

Review Comment:
   Discussed offline - will leave it as is for now as the suggestion wouldn't be making it clearer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] mukund-thakur commented on a diff in pull request #4499: HADOOP-18320. Fixes typos in Delegation Tokens documentation.

Posted by GitBox <gi...@apache.org>.
mukund-thakur commented on code in PR #4499:
URL: https://github.com/apache/hadoop/pull/4499#discussion_r1062124836


##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md:
##########
@@ -108,7 +108,7 @@ password-protected data opaque to clients; they contain the secrets needed
 to access the relevant S3 buckets and associated services.
 
 They are obtained by requesting a delegation token from the S3A filesystem client.

Review Comment:
   Not sure why github not allowing me to comment at L82. 
   Delegation "Token" support is 



##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md:
##########
@@ -108,7 +108,7 @@ password-protected data opaque to clients; they contain the secrets needed
 to access the relevant S3 buckets and associated services.
 
 They are obtained by requesting a delegation token from the S3A filesystem client.

Review Comment:
   l120 : It -> it.



##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md:
##########
@@ -108,7 +108,7 @@ password-protected data opaque to clients; they contain the secrets needed
 to access the relevant S3 buckets and associated services.
 
 They are obtained by requesting a delegation token from the S3A filesystem client.

Review Comment:
   L106 -> These S3A Delegation Tokens are special in "a way" that 



##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md:
##########
@@ -353,10 +352,10 @@ it is authenticated with; the role token binding will fail.
 
 When the AWS credentials supplied to the Session Delegation Token binding
 through `fs.s3a.aws.credentials.provider` are themselves a set of

Review Comment:
   Something is off here, maybe "they themselves are part of session credentials."



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] ahmarsuhail commented on pull request #4499: HADOOP-18320. Fixes typos in Delegation Tokens documentation.

Posted by GitBox <gi...@apache.org>.
ahmarsuhail commented on PR #4499:
URL: https://github.com/apache/hadoop/pull/4499#issuecomment-1372112947

   thanks for taking a look @mukund-thakur, have made the suggested changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org