You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@apache.org> on 2015/09/01 19:17:19 UTC
Review Request 38010: Stop in-progress instances from pulsing when
update has been aborted.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38010/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Bill Farner.
Repository: aurora
Description
-------
Stop in-progress instances from pulsing when update has been aborted.
Also removed the "INSTANCE-" prefix from tooltip as it seemed superfluous and added "ABORTED" to the tooltip for instances that were "UPDATING" when the update was aborted. An argument can be made for adding "ABORTED" to the tooltip for all non-terminal states (PENDING, etc.), let me know if you think we should add it for those as well.
Diffs
-----
src/main/resources/scheduler/assets/css/app.css 9437c53e695d1c4009d9df5fb23e34479f5b3d2d
src/main/resources/scheduler/assets/js/directives.js d8f722c441b9399e7eacd6ae29966b3fb24a422d
src/main/resources/scheduler/assets/update.html c8867093338593e5561e42fdee7cc5f15be0356e
Diff: https://reviews.apache.org/r/38010/diff/
Testing
-------
./gradlew jshint
Verified the pulsing stops for an aborted update. Also see screenshot for tooltip changes.
File Attachments
----------------
Screen Shot 2015-09-01 at 12.08.51 PM.png
https://reviews.apache.org/media/uploaded/files/2015/09/01/340c71be-564f-4024-8ee3-bab960edfad0__Screen_Shot_2015-09-01_at_12.08.51_PM.png
Thanks,
Joshua Cohen
Re: Review Request 38010: Stop in-progress instances from pulsing when
update has been aborted.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38010/#review97310
-----------------------------------------------------------
Master (5a7bd34) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Sept. 1, 2015, 5:29 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38010/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 5:29 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Stop in-progress instances from pulsing when update has been aborted.
>
> Also removed the "INSTANCE-" prefix from tooltip as it seemed superfluous and added "ABORTED" to the tooltip for instances that were "UPDATING" when the update was aborted. An argument can be made for adding "ABORTED" to the tooltip for all non-terminal states (PENDING, etc.), let me know if you think we should add it for those as well.
>
>
> Diffs
> -----
>
> src/main/resources/scheduler/assets/css/app.css 9437c53e695d1c4009d9df5fb23e34479f5b3d2d
> src/main/resources/scheduler/assets/js/directives.js d8f722c441b9399e7eacd6ae29966b3fb24a422d
> src/main/resources/scheduler/assets/update.html c8867093338593e5561e42fdee7cc5f15be0356e
>
> Diff: https://reviews.apache.org/r/38010/diff/
>
>
> Testing
> -------
>
> ./gradlew jshint
>
> Verified the pulsing stops for an aborted update. Also see screenshot for tooltip changes.
>
>
> File Attachments
> ----------------
>
> Screen Shot 2015-09-01 at 12.08.51 PM.png
> https://reviews.apache.org/media/uploaded/files/2015/09/01/340c71be-564f-4024-8ee3-bab960edfad0__Screen_Shot_2015-09-01_at_12.08.51_PM.png
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 38010: Stop in-progress instances from pulsing when
update has been aborted.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38010/#review97323
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On Sept. 1, 2015, 5:29 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38010/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 5:29 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Stop in-progress instances from pulsing when update has been aborted.
>
> Also removed the "INSTANCE-" prefix from tooltip as it seemed superfluous and added "ABORTED" to the tooltip for instances that were "UPDATING" when the update was aborted. An argument can be made for adding "ABORTED" to the tooltip for all non-terminal states (PENDING, etc.), let me know if you think we should add it for those as well.
>
>
> Diffs
> -----
>
> src/main/resources/scheduler/assets/css/app.css 9437c53e695d1c4009d9df5fb23e34479f5b3d2d
> src/main/resources/scheduler/assets/js/directives.js d8f722c441b9399e7eacd6ae29966b3fb24a422d
> src/main/resources/scheduler/assets/update.html c8867093338593e5561e42fdee7cc5f15be0356e
>
> Diff: https://reviews.apache.org/r/38010/diff/
>
>
> Testing
> -------
>
> ./gradlew jshint
>
> Verified the pulsing stops for an aborted update. Also see screenshot for tooltip changes.
>
>
> File Attachments
> ----------------
>
> Screen Shot 2015-09-01 at 12.08.51 PM.png
> https://reviews.apache.org/media/uploaded/files/2015/09/01/340c71be-564f-4024-8ee3-bab960edfad0__Screen_Shot_2015-09-01_at_12.08.51_PM.png
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 38010: Stop in-progress instances from pulsing when
update has been aborted.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38010/#review97384
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Sept. 1, 2015, 10:29 a.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38010/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 10:29 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Stop in-progress instances from pulsing when update has been aborted.
>
> Also removed the "INSTANCE-" prefix from tooltip as it seemed superfluous and added "ABORTED" to the tooltip for instances that were "UPDATING" when the update was aborted. An argument can be made for adding "ABORTED" to the tooltip for all non-terminal states (PENDING, etc.), let me know if you think we should add it for those as well.
>
>
> Diffs
> -----
>
> src/main/resources/scheduler/assets/css/app.css 9437c53e695d1c4009d9df5fb23e34479f5b3d2d
> src/main/resources/scheduler/assets/js/directives.js d8f722c441b9399e7eacd6ae29966b3fb24a422d
> src/main/resources/scheduler/assets/update.html c8867093338593e5561e42fdee7cc5f15be0356e
>
> Diff: https://reviews.apache.org/r/38010/diff/
>
>
> Testing
> -------
>
> ./gradlew jshint
>
> Verified the pulsing stops for an aborted update. Also see screenshot for tooltip changes.
>
>
> File Attachments
> ----------------
>
> Screen Shot 2015-09-01 at 12.08.51 PM.png
> https://reviews.apache.org/media/uploaded/files/2015/09/01/340c71be-564f-4024-8ee3-bab960edfad0__Screen_Shot_2015-09-01_at_12.08.51_PM.png
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 38010: Stop in-progress instances from pulsing when
update has been aborted.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38010/
-----------------------------------------------------------
(Updated Sept. 1, 2015, 5:29 p.m.)
Review request for Aurora, David McLaughlin and Bill Farner.
Changes
-------
Apparently gradle task names are case sensitive!
Repository: aurora
Description
-------
Stop in-progress instances from pulsing when update has been aborted.
Also removed the "INSTANCE-" prefix from tooltip as it seemed superfluous and added "ABORTED" to the tooltip for instances that were "UPDATING" when the update was aborted. An argument can be made for adding "ABORTED" to the tooltip for all non-terminal states (PENDING, etc.), let me know if you think we should add it for those as well.
Diffs (updated)
-----
src/main/resources/scheduler/assets/css/app.css 9437c53e695d1c4009d9df5fb23e34479f5b3d2d
src/main/resources/scheduler/assets/js/directives.js d8f722c441b9399e7eacd6ae29966b3fb24a422d
src/main/resources/scheduler/assets/update.html c8867093338593e5561e42fdee7cc5f15be0356e
Diff: https://reviews.apache.org/r/38010/diff/
Testing
-------
./gradlew jshint
Verified the pulsing stops for an aborted update. Also see screenshot for tooltip changes.
File Attachments
----------------
Screen Shot 2015-09-01 at 12.08.51 PM.png
https://reviews.apache.org/media/uploaded/files/2015/09/01/340c71be-564f-4024-8ee3-bab960edfad0__Screen_Shot_2015-09-01_at_12.08.51_PM.png
Thanks,
Joshua Cohen
Re: Review Request 38010: Stop in-progress instances from pulsing when
update has been aborted.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38010/#review97307
-----------------------------------------------------------
Master (f285647) is red with this patch.
./build-support/jenkins/build.sh
Note: Recompile with -Xlint:unchecked for details.
:commons:generateThriftResources
:commons:processResources
:commons:classes
:commons:jar
:compileJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
'JobUpdateStatus' is not defined. (/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/resources/scheduler/assets/js/directives.js:173:42)
> var aborted = scope.status === JobUpdateStatus.ABORTED;
:jsHint FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':jsHint'.
> Process 'command '/home/jenkins/jenkins-slave/tools/hudson.model.JDK/jdk1.8.0_45/bin/java'' finished with non-zero exit value 2
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 1 mins 33.774 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Sept. 1, 2015, 5:17 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38010/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 5:17 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Stop in-progress instances from pulsing when update has been aborted.
>
> Also removed the "INSTANCE-" prefix from tooltip as it seemed superfluous and added "ABORTED" to the tooltip for instances that were "UPDATING" when the update was aborted. An argument can be made for adding "ABORTED" to the tooltip for all non-terminal states (PENDING, etc.), let me know if you think we should add it for those as well.
>
>
> Diffs
> -----
>
> src/main/resources/scheduler/assets/css/app.css 9437c53e695d1c4009d9df5fb23e34479f5b3d2d
> src/main/resources/scheduler/assets/js/directives.js d8f722c441b9399e7eacd6ae29966b3fb24a422d
> src/main/resources/scheduler/assets/update.html c8867093338593e5561e42fdee7cc5f15be0356e
>
> Diff: https://reviews.apache.org/r/38010/diff/
>
>
> Testing
> -------
>
> ./gradlew jshint
>
> Verified the pulsing stops for an aborted update. Also see screenshot for tooltip changes.
>
>
> File Attachments
> ----------------
>
> Screen Shot 2015-09-01 at 12.08.51 PM.png
> https://reviews.apache.org/media/uploaded/files/2015/09/01/340c71be-564f-4024-8ee3-bab960edfad0__Screen_Shot_2015-09-01_at_12.08.51_PM.png
>
>
> Thanks,
>
> Joshua Cohen
>
>