[GitHub] [hive] ayushtkn commented on pull request #4137: HIVE-27113: Increasing default for hive.thrift.client.max.message.siz…

["ayushtkn (via GitHub)" <gi...@apache.org>]

ayushtkn commented on PR #4137:
URL: https://github.com/apache/hive/pull/4137#issuecomment-1600719161

   The PR has some ~1800 failures when it got merged, and it seems to be bothering other commits, I have reverted this for now.
   http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-4137/8/pipeline
   
   Most probably this line is wrong
   ```
    int maxThriftMessageSize = (int) Math.min(conf.getSizeVar(HiveConf.ConfVars.HIVE_THRIFT_CLIENT_MAX_MESSAGE_SIZE),Integer.MAX_VALUE);
   ```
   
   you have changed the sizeVar to a number earlier it was 1gb now it is a number, so you need to do a getIntVar or something of that sort.
   
   The tests are failing with that
   ```
   Caused by: java.lang.AssertionError
   	at org.apache.hadoop.hive.metastore.conf.MetastoreConf.getVar(MetastoreConf.java:2164)
   	at org.apache.hadoop.hive.metastore.conf.MetastoreConf.getSizeVar(MetastoreConf.java:2316)
   	at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.configureThriftMaxMessageSize(HiveMetaStoreClient.java:613)
   ```
   ([http://ci.hive.apache.org/job/hive-precommit/job/PR-4137/8/testReport/junit/org.apach[…]/TestHS2SessionHive/Testing___split_09___PostProcess______/](http://ci.hive.apache.org/job/hive-precommit/job/PR-4137/8/testReport/junit/org.apache.hive.service.server/TestHS2SessionHive/Testing___split_09___PostProcess______/))


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org