You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2006/09/04 05:37:20 UTC
[Bug 5080] New: RCVD_ILLEGAL_IP doesn't hit as much as it should
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5080
Summary: RCVD_ILLEGAL_IP doesn't hit as much as it should
Product: Spamassassin
Version: 3.1.5
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P5
Component: Rules (Eval Tests)
AssignedTo: dev@spamassassin.apache.org
ReportedBy: felicity@apache.org
I got a mail from somsone who mentioned that the RE in check_for_illegal_ip()
doesn't properly match the 127/8 addresses, because it's klugily written to
avoid 127.0.0.1. I'll put up a patch shortly to deal with it -- in my testing
the result improve, though not dramatically:
0.930 1.0948 0.0000 1.000 1.00 1.00 RCVD_ILLEGAL_IP2
0.909 1.0709 0.0000 1.000 0.50 1.00 RCVD_ILLEGAL_IP
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5080] [review] RCVD_ILLEGAL_IP doesn't hit as much as it should
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5080
------- Additional Comments From spamassassin@dostech.ca 2006-09-29 11:58 -------
[dos@FC5-VPC trunk]$ svn ci -m "bug 5080: fix bug in update RCVD_ILLEGAL_IP
evaltest to properly deal with 127/8 fix"
Sending lib/Mail/SpamAssassin/Plugin/RelayEval.pm
Transmitting file data .
Committed revision 451385.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5080] [review] RCVD_ILLEGAL_IP doesn't hit as much as it should
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5080
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes |needs 1 vote
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5080] [review] RCVD_ILLEGAL_IP doesn't hit as much as it should
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5080
------- Additional Comments From jm@jmason.org 2006-09-04 09:26 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5080] [review] RCVD_ILLEGAL_IP doesn't hit as much as it should
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5080
------- Additional Comments From spamassassin@dostech.ca 2006-09-18 06:25 -------
-1 on 3681... this line should be a "next if":
+ return 0 if ($check eq '127.0.0.1');
I'm drowsy, but it looks like there's an unneeded (?: ) pair too.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5080] [review] RCVD_ILLEGAL_IP doesn't hit as much as it should
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5080
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From spamassassin@dostech.ca 2006-10-03 15:56 -------
[dos@FC5-VPC 3.1]$ svn ci -m "bug 5080: fix bug in update RCVD_ILLEGAL_IP
evaltest to properly deal with 127/8 fix"
Sending lib/Mail/SpamAssassin/EvalTests.pm
Transmitting file data .
Committed revision 452667.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5080] [review] RCVD_ILLEGAL_IP doesn't hit as much as it should
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5080
------- Additional Comments From jm@jmason.org 2006-10-02 07:36 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5080] [review] RCVD_ILLEGAL_IP doesn't hit as much as it should
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5080
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|RCVD_ILLEGAL_IP doesn't hit |[review] RCVD_ILLEGAL_IP
|as much as it should |doesn't hit as much as it
| |should
Status Whiteboard| |needs 2 votes
Target Milestone|Undefined |3.1.6
------- Additional Comments From felicity@apache.org 2006-09-04 03:43 -------
patch coming shortly. committed to 3.2 as r439916
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5080] [review] RCVD_ILLEGAL_IP doesn't hit as much as it should
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5080
------- Additional Comments From felicity@apache.org 2006-09-04 03:43 -------
Created an attachment (id=3681)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3681&action=view)
suggested patch
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5080] [review] RCVD_ILLEGAL_IP doesn't hit as much as it should
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5080
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #3681 is|0 |1
obsolete| |
------- Additional Comments From spamassassin@dostech.ca 2006-09-29 11:58 -------
Created an attachment (id=3709)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3709&action=view)
suggested patch
checks all IPs, not just the ones up to the first 127.0.0.1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5080] [review] RCVD_ILLEGAL_IP doesn't hit as much as it should
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5080
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 vote |ready to commit
------- Additional Comments From sidney@sidney.com 2006-10-03 15:24 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.