You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "shaokeyibb (via GitHub)" <gi...@apache.org> on 2024/11/05 14:41:18 UTC
[PR] [Dubbo-SPI-Extensions] Add Intergration Test [dubbo-spi-extensions]
shaokeyibb opened a new pull request, #556:
URL: https://github.com/apache/dubbo-spi-extensions/pull/556
## What is the purpose of the change
See: [[General][Java SDK (Component)] Integrate spi-samples into github-action in the spi repository](https://github.com/apache/dubbo/discussions/14862)
Implemented an "intergration-test" github actions job.
## Brief changelog
- Modifed `.github/workflows/build-and-test-pr.yml`, add a new job named "intergration-test".
## Verifying this change
Just see the "Intergration Test with JDK 8" checks below.
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before
you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit
in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
exist. If the new feature or significant change is committed, please remember to add sample
in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [x] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure
unit-test and integration-test pass.
- [x] If this contribution is large, please follow
the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [Dubbo-SPI-Extensions] Add Intergration Test [dubbo-spi-extensions]
Posted by "shaokeyibb (via GitHub)" <gi...@apache.org>.
shaokeyibb commented on code in PR #556:
URL: https://github.com/apache/dubbo-spi-extensions/pull/556#discussion_r1830309532
##########
.github/workflows/build-and-test-pr.yml:
##########
@@ -338,3 +338,69 @@ jobs:
# with:
# name: "error-inspection-result"
# path: ${{ github.workspace }}/dubbo-test-tools/dubbo-error-code-inspector/error-inspection-result.txt
+
+ intergration-test:
+ needs: [check-license, build-source, unit-test-prepare]
+ name: "Intergration Test with JDK ${{ matrix.jdk }}"
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ jdk: [8, 11]
+ fail-fast: false
+ env:
+ DISABLE_FILE_SYSTEM_TEST: true
+ CURRENT_ROLE: ${{ matrix.case-role }}
+ steps:
+ - name: Checkout Self
+ uses: actions/checkout@v4
+ - name: Checkout dubbo-spi-samples
+ uses: actions/checkout@v4
+ with:
+ repository: apache/dubbo-spi-samples
+ path: dubbo-spi-samples
+ - name: "Set up JDK ${{ matrix.jdk }}"
+ uses: actions/setup-java@v4
+ with:
+ distribution: "zulu"
+ java-version: ${{ matrix.jdk }}
+ - uses: actions/cache@v4
+ name: "Cache local Maven repository"
+ with:
+ path: ~/.m2/repository
+ key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}-${{ github.run_id }}
+ restore-keys: |
+ ${{ runner.os }}-maven-
+ ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+ - uses: actions/cache@v4
+ name: "Cache zookeeper binary archive"
+ id: "cache-zookeeper"
+ with:
+ path: ${{ github.workspace }}/.tmp/zookeeper
+ key: zookeeper-${{ runner.os }}-${{ env.ZOOKEEPER_VERSION }}
+ restore-keys: |
+ zookeeper-${{ runner.os }}-
+ - uses: actions/cache@v4
+ name: "Cache secret key"
+ id: "cache-secret-cert"
+ with:
+ path: ${{ github.workspace }}/.tmp/rsa
+ key: secret-rsa-${{ runner.os }}-${{ github.run_id }}
+ - name: Calc Dubbo Version
Review Comment:
I think it's a known issue since most of spi-samples require their dubbo version to `3.2*` instad of our 3.3 which is configured in `case-versions.conf`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [Dubbo-SPI-Extensions] Add Intergration Test [dubbo-spi-extensions]
Posted by "shaokeyibb (via GitHub)" <gi...@apache.org>.
shaokeyibb closed pull request #556: [Dubbo-SPI-Extensions] Add Intergration Test
URL: https://github.com/apache/dubbo-spi-extensions/pull/556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [Dubbo-SPI-Extensions] Add Intergration Test [dubbo-spi-extensions]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #556:
URL: https://github.com/apache/dubbo-spi-extensions/pull/556#issuecomment-2457399253
## [Codecov](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/556?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 0.00%. Comparing base [(`9b48975`)](https://app.codecov.io/gh/apache/dubbo-spi-extensions/commit/9b48975e2e8c5d996bc25319fe7c93f0e3582be0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`7e5b2e3`)](https://app.codecov.io/gh/apache/dubbo-spi-extensions/commit/7e5b2e35907905ee87ebd4a6fec08cd5c17c345a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 188 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #556 +/- ##
===========================================
- Coverage 0.27% 0.00% -0.28%
===========================================
Files 299 525 +226
Lines 13730 17560 +3830
Branches 1737 2039 +302
===========================================
- Hits 38 0 -38
- Misses 13689 17560 +3871
+ Partials 3 0 -3
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/556?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [Dubbo-SPI-Extensions] Add Intergration Test [dubbo-spi-extensions]
Posted by "wcy666103 (via GitHub)" <gi...@apache.org>.
wcy666103 commented on code in PR #556:
URL: https://github.com/apache/dubbo-spi-extensions/pull/556#discussion_r1830318943
##########
.github/workflows/build-and-test-pr.yml:
##########
@@ -338,3 +338,69 @@ jobs:
# with:
# name: "error-inspection-result"
# path: ${{ github.workspace }}/dubbo-test-tools/dubbo-error-code-inspector/error-inspection-result.txt
+
+ intergration-test:
+ needs: [check-license, build-source, unit-test-prepare]
+ name: "Intergration Test with JDK ${{ matrix.jdk }}"
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ jdk: [8, 11]
+ fail-fast: false
+ env:
+ DISABLE_FILE_SYSTEM_TEST: true
+ CURRENT_ROLE: ${{ matrix.case-role }}
+ steps:
+ - name: Checkout Self
+ uses: actions/checkout@v4
+ - name: Checkout dubbo-spi-samples
+ uses: actions/checkout@v4
+ with:
+ repository: apache/dubbo-spi-samples
+ path: dubbo-spi-samples
+ - name: "Set up JDK ${{ matrix.jdk }}"
+ uses: actions/setup-java@v4
+ with:
+ distribution: "zulu"
+ java-version: ${{ matrix.jdk }}
+ - uses: actions/cache@v4
+ name: "Cache local Maven repository"
+ with:
+ path: ~/.m2/repository
+ key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}-${{ github.run_id }}
+ restore-keys: |
+ ${{ runner.os }}-maven-
+ ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+ - uses: actions/cache@v4
+ name: "Cache zookeeper binary archive"
+ id: "cache-zookeeper"
+ with:
+ path: ${{ github.workspace }}/.tmp/zookeeper
+ key: zookeeper-${{ runner.os }}-${{ env.ZOOKEEPER_VERSION }}
+ restore-keys: |
+ zookeeper-${{ runner.os }}-
+ - uses: actions/cache@v4
+ name: "Cache secret key"
+ id: "cache-secret-cert"
+ with:
+ path: ${{ github.workspace }}/.tmp/rsa
+ key: secret-rsa-${{ runner.os }}-${{ github.run_id }}
+ - name: Calc Dubbo Version
Review Comment:
> I think it's a known issue since most of spi-samples require their dubbo version to `3.2*` instad of our 3.3 which is configured in `case-versions.conf`.
So the logic of the spi-samples repository is broken, and I think it's enough to limit the spi-extensions version. The current configuration of the samples repository is just for use, not anything special.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [Dubbo-SPI-Extensions] Add Intergration Test [dubbo-spi-extensions]
Posted by "shaokeyibb (via GitHub)" <gi...@apache.org>.
shaokeyibb commented on code in PR #556:
URL: https://github.com/apache/dubbo-spi-extensions/pull/556#discussion_r1830309532
##########
.github/workflows/build-and-test-pr.yml:
##########
@@ -338,3 +338,69 @@ jobs:
# with:
# name: "error-inspection-result"
# path: ${{ github.workspace }}/dubbo-test-tools/dubbo-error-code-inspector/error-inspection-result.txt
+
+ intergration-test:
+ needs: [check-license, build-source, unit-test-prepare]
+ name: "Intergration Test with JDK ${{ matrix.jdk }}"
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ jdk: [8, 11]
+ fail-fast: false
+ env:
+ DISABLE_FILE_SYSTEM_TEST: true
+ CURRENT_ROLE: ${{ matrix.case-role }}
+ steps:
+ - name: Checkout Self
+ uses: actions/checkout@v4
+ - name: Checkout dubbo-spi-samples
+ uses: actions/checkout@v4
+ with:
+ repository: apache/dubbo-spi-samples
+ path: dubbo-spi-samples
+ - name: "Set up JDK ${{ matrix.jdk }}"
+ uses: actions/setup-java@v4
+ with:
+ distribution: "zulu"
+ java-version: ${{ matrix.jdk }}
+ - uses: actions/cache@v4
+ name: "Cache local Maven repository"
+ with:
+ path: ~/.m2/repository
+ key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}-${{ github.run_id }}
+ restore-keys: |
+ ${{ runner.os }}-maven-
+ ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+ - uses: actions/cache@v4
+ name: "Cache zookeeper binary archive"
+ id: "cache-zookeeper"
+ with:
+ path: ${{ github.workspace }}/.tmp/zookeeper
+ key: zookeeper-${{ runner.os }}-${{ env.ZOOKEEPER_VERSION }}
+ restore-keys: |
+ zookeeper-${{ runner.os }}-
+ - uses: actions/cache@v4
+ name: "Cache secret key"
+ id: "cache-secret-cert"
+ with:
+ path: ${{ github.workspace }}/.tmp/rsa
+ key: secret-rsa-${{ runner.os }}-${{ github.run_id }}
+ - name: Calc Dubbo Version
Review Comment:
I think it's a known issue since most of spi-samples require their dubbo version to `3.2*` which is configured in `case-versions.conf` instad of our 3.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [Dubbo-SPI-Extensions] Add Intergration Test [dubbo-spi-extensions]
Posted by "wcy666103 (via GitHub)" <gi...@apache.org>.
wcy666103 commented on code in PR #556:
URL: https://github.com/apache/dubbo-spi-extensions/pull/556#discussion_r1830300789
##########
.github/workflows/build-and-test-pr.yml:
##########
@@ -338,3 +338,69 @@ jobs:
# with:
# name: "error-inspection-result"
# path: ${{ github.workspace }}/dubbo-test-tools/dubbo-error-code-inspector/error-inspection-result.txt
+
+ intergration-test:
+ needs: [check-license, build-source, unit-test-prepare]
+ name: "Intergration Test with JDK ${{ matrix.jdk }}"
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ jdk: [8, 11]
+ fail-fast: false
+ env:
+ DISABLE_FILE_SYSTEM_TEST: true
+ CURRENT_ROLE: ${{ matrix.case-role }}
+ steps:
+ - name: Checkout Self
+ uses: actions/checkout@v4
+ - name: Checkout dubbo-spi-samples
+ uses: actions/checkout@v4
+ with:
+ repository: apache/dubbo-spi-samples
+ path: dubbo-spi-samples
+ - name: "Set up JDK ${{ matrix.jdk }}"
+ uses: actions/setup-java@v4
+ with:
+ distribution: "zulu"
+ java-version: ${{ matrix.jdk }}
+ - uses: actions/cache@v4
+ name: "Cache local Maven repository"
+ with:
+ path: ~/.m2/repository
+ key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}-${{ github.run_id }}
+ restore-keys: |
+ ${{ runner.os }}-maven-
+ ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+ - uses: actions/cache@v4
+ name: "Cache zookeeper binary archive"
+ id: "cache-zookeeper"
+ with:
+ path: ${{ github.workspace }}/.tmp/zookeeper
+ key: zookeeper-${{ runner.os }}-${{ env.ZOOKEEPER_VERSION }}
+ restore-keys: |
+ zookeeper-${{ runner.os }}-
+ - uses: actions/cache@v4
+ name: "Cache secret key"
+ id: "cache-secret-cert"
+ with:
+ path: ${{ github.workspace }}/.tmp/rsa
+ key: secret-rsa-${{ runner.os }}-${{ github.run_id }}
+ - name: Calc Dubbo Version
Review Comment:
This approach does not integrate the two test environments very well, you can check the log of the action, all tests are ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org