You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/16 06:18:56 UTC
[GitHub] [iotdb] AuroraLiu0823 opened a new issue, #7013: Define a constant instead of duplicating this literal "total" 8 times.
AuroraLiu0823 opened a new issue, #7013:
URL: https://github.com/apache/iotdb/issues/7013
Code Path:confignode/src/main/java/org/apache/iotdb/confignode/manager/load/LoadManagerMetrics.java
<img width="623" alt="1660630501280" src="https://user-images.githubusercontent.com/111332545/184810462-ecb5aa6a-8952-4dec-924b-1dd4b51d77e6.png">
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] auula commented on issue #7013: Define a constant instead of duplicating this literal "total" 8 times.
Posted by GitBox <gi...@apache.org>.
auula commented on issue #7013:
URL: https://github.com/apache/iotdb/issues/7013#issuecomment-1290479495
> Has this issue been fixed? 'total' seems to be defined as METRIC_STATUS_ONELINE
i have seen too，it seems that is : METRIC_TAG_TOTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] team-317 commented on issue #7013: Define a constant instead of duplicating this literal "total" 8 times.
Posted by GitBox <gi...@apache.org>.
team-317 commented on issue #7013:
URL: https://github.com/apache/iotdb/issues/7013#issuecomment-1290520743
So this issue can be closed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] auula commented on issue #7013: Define a constant instead of duplicating this literal "total" 8 times.
Posted by GitBox <gi...@apache.org>.
auula commented on issue #7013:
URL: https://github.com/apache/iotdb/issues/7013#issuecomment-1297285024
The current requirement seems fine, I additionally changed the other strings to constants #7835 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] GuanchuShen commented on issue #7013: Define a constant instead of duplicating this literal "total" 8 times.
Posted by GitBox <gi...@apache.org>.
GuanchuShen commented on issue #7013:
URL: https://github.com/apache/iotdb/issues/7013#issuecomment-1217853124
[WeOpen Star]I would like to help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] team-317 commented on issue #7013: Define a constant instead of duplicating this literal "total" 8 times.
Posted by GitBox <gi...@apache.org>.
team-317 commented on issue #7013:
URL: https://github.com/apache/iotdb/issues/7013#issuecomment-1290468272
Has this issue been fixed? 'total' seems to be defined as METRIC_STATUS_ONELINE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] github-actions[bot] commented on issue #7013: Define a constant instead of duplicating this literal "total" 8 times.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #7013:
URL: https://github.com/apache/iotdb/issues/7013#issuecomment-1216205705
Hi, this is your first issue in IoTDB project. Thanks for your report. Welcome to join the community!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org