You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2008/01/16 16:40:35 UTC
[jira] Created: (LUCENE-1136) add ability to not count sub-task
doLogic increment to contri/benchmark
add ability to not count sub-task doLogic increment to contri/benchmark
-----------------------------------------------------------------------
Key: LUCENE-1136
URL: https://issues.apache.org/jira/browse/LUCENE-1136
Project: Lucene - Java
Issue Type: Improvement
Components: contrib/benchmark
Reporter: Michael McCandless
Priority: Minor
Fix For: 2.4
Sometimes, you want to run a sub-task like CloseIndex, and include the time it takes to run, but not include the count that it returns when reporting rec/s.
We could adopt this approach: if a task is preceded by a "-" character, then, do not count the value returned by doLogic.
See discussion leading to this here:
http://www.gossamer-threads.com/lists/lucene/java-dev/57081
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1136) add ability to not count sub-task
doLogic increment to contri/benchmark
Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doron Cohen resolved LUCENE-1136.
---------------------------------
Resolution: Fixed
Lucene Fields: [Patch Available] (was: [New])
Committed.
> add ability to not count sub-task doLogic increment to contri/benchmark
> -----------------------------------------------------------------------
>
> Key: LUCENE-1136
> URL: https://issues.apache.org/jira/browse/LUCENE-1136
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark
> Reporter: Michael McCandless
> Assignee: Doron Cohen
> Priority: Minor
> Fix For: 2.4
>
> Attachments: lucene-1136.patch, lucene-1136.patch, lucene-1136.patch
>
>
> Sometimes, you want to run a sub-task like CloseIndex, and include the time it takes to run, but not include the count that it returns when reporting rec/s.
> We could adopt this approach: if a task is preceded by a "-" character, then, do not count the value returned by doLogic.
> See discussion leading to this here:
> http://www.gossamer-threads.com/lists/lucene/java-dev/57081
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-1136) add ability to not count sub-task
doLogic increment to contri/benchmark
Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doron Cohen reassigned LUCENE-1136:
-----------------------------------
Assignee: Doron Cohen
> add ability to not count sub-task doLogic increment to contri/benchmark
> -----------------------------------------------------------------------
>
> Key: LUCENE-1136
> URL: https://issues.apache.org/jira/browse/LUCENE-1136
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark
> Reporter: Michael McCandless
> Assignee: Doron Cohen
> Priority: Minor
> Fix For: 2.4
>
>
> Sometimes, you want to run a sub-task like CloseIndex, and include the time it takes to run, but not include the count that it returns when reporting rec/s.
> We could adopt this approach: if a task is preceded by a "-" character, then, do not count the value returned by doLogic.
> See discussion leading to this here:
> http://www.gossamer-threads.com/lists/lucene/java-dev/57081
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1136) add ability to not count sub-task
doLogic increment to contri/benchmark
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559888#action_12559888 ]
Michael McCandless commented on LUCENE-1136:
--------------------------------------------
It works like a charm! And, all tests pass. Thanks Doron.
The only minor thing I noticed was when it prints out the alg it's about to execute, the "-" is not included.
> add ability to not count sub-task doLogic increment to contri/benchmark
> -----------------------------------------------------------------------
>
> Key: LUCENE-1136
> URL: https://issues.apache.org/jira/browse/LUCENE-1136
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark
> Reporter: Michael McCandless
> Assignee: Doron Cohen
> Priority: Minor
> Fix For: 2.4
>
> Attachments: lucene-1136.patch
>
>
> Sometimes, you want to run a sub-task like CloseIndex, and include the time it takes to run, but not include the count that it returns when reporting rec/s.
> We could adopt this approach: if a task is preceded by a "-" character, then, do not count the value returned by doLogic.
> See discussion leading to this here:
> http://www.gossamer-threads.com/lists/lucene/java-dev/57081
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1136) add ability to not count sub-task
doLogic increment to contri/benchmark
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561334#action_12561334 ]
Michael McCandless commented on LUCENE-1136:
--------------------------------------------
Doron, do you plan to commit this soon?
> add ability to not count sub-task doLogic increment to contri/benchmark
> -----------------------------------------------------------------------
>
> Key: LUCENE-1136
> URL: https://issues.apache.org/jira/browse/LUCENE-1136
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark
> Reporter: Michael McCandless
> Assignee: Doron Cohen
> Priority: Minor
> Fix For: 2.4
>
> Attachments: lucene-1136.patch, lucene-1136.patch
>
>
> Sometimes, you want to run a sub-task like CloseIndex, and include the time it takes to run, but not include the count that it returns when reporting rec/s.
> We could adopt this approach: if a task is preceded by a "-" character, then, do not count the value returned by doLogic.
> See discussion leading to this here:
> http://www.gossamer-threads.com/lists/lucene/java-dev/57081
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1136) add ability to not count sub-task
doLogic increment to contri/benchmark
Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doron Cohen updated LUCENE-1136:
--------------------------------
Attachment: lucene-1136.patch
Good catch!
This patch fixes that - printing the '-' for tasks with disableCounting set.
> add ability to not count sub-task doLogic increment to contri/benchmark
> -----------------------------------------------------------------------
>
> Key: LUCENE-1136
> URL: https://issues.apache.org/jira/browse/LUCENE-1136
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark
> Reporter: Michael McCandless
> Assignee: Doron Cohen
> Priority: Minor
> Fix For: 2.4
>
> Attachments: lucene-1136.patch, lucene-1136.patch
>
>
> Sometimes, you want to run a sub-task like CloseIndex, and include the time it takes to run, but not include the count that it returns when reporting rec/s.
> We could adopt this approach: if a task is preceded by a "-" character, then, do not count the value returned by doLogic.
> See discussion leading to this here:
> http://www.gossamer-threads.com/lists/lucene/java-dev/57081
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1136) add ability to not count sub-task
doLogic increment to contri/benchmark
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560314#action_12560314 ]
Michael McCandless commented on LUCENE-1136:
--------------------------------------------
OK, 2nd patch now prints the "-", and all tests pass! Thanks Doron.
> add ability to not count sub-task doLogic increment to contri/benchmark
> -----------------------------------------------------------------------
>
> Key: LUCENE-1136
> URL: https://issues.apache.org/jira/browse/LUCENE-1136
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark
> Reporter: Michael McCandless
> Assignee: Doron Cohen
> Priority: Minor
> Fix For: 2.4
>
> Attachments: lucene-1136.patch, lucene-1136.patch
>
>
> Sometimes, you want to run a sub-task like CloseIndex, and include the time it takes to run, but not include the count that it returns when reporting rec/s.
> We could adopt this approach: if a task is preceded by a "-" character, then, do not count the value returned by doLogic.
> See discussion leading to this here:
> http://www.gossamer-threads.com/lists/lucene/java-dev/57081
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1136) add ability to not count sub-task
doLogic increment to contri/benchmark
Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doron Cohen updated LUCENE-1136:
--------------------------------
Attachment: lucene-1136.patch
This patch should do it.
Give it a try Mike?
(patch also fixing a minor issue in benchmarks execution where the outer most task did not report its stats even in the case that it was named in the algorithm.)
> add ability to not count sub-task doLogic increment to contri/benchmark
> -----------------------------------------------------------------------
>
> Key: LUCENE-1136
> URL: https://issues.apache.org/jira/browse/LUCENE-1136
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark
> Reporter: Michael McCandless
> Assignee: Doron Cohen
> Priority: Minor
> Fix For: 2.4
>
> Attachments: lucene-1136.patch
>
>
> Sometimes, you want to run a sub-task like CloseIndex, and include the time it takes to run, but not include the count that it returns when reporting rec/s.
> We could adopt this approach: if a task is preceded by a "-" character, then, do not count the value returned by doLogic.
> See discussion leading to this here:
> http://www.gossamer-threads.com/lists/lucene/java-dev/57081
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1136) add ability to not count sub-task
doLogic increment to contri/benchmark
Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doron Cohen updated LUCENE-1136:
--------------------------------
Attachment: lucene-1136.patch
updated patch for reference (integrated with recent changes).
> add ability to not count sub-task doLogic increment to contri/benchmark
> -----------------------------------------------------------------------
>
> Key: LUCENE-1136
> URL: https://issues.apache.org/jira/browse/LUCENE-1136
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark
> Reporter: Michael McCandless
> Assignee: Doron Cohen
> Priority: Minor
> Fix For: 2.4
>
> Attachments: lucene-1136.patch, lucene-1136.patch, lucene-1136.patch
>
>
> Sometimes, you want to run a sub-task like CloseIndex, and include the time it takes to run, but not include the count that it returns when reporting rec/s.
> We could adopt this approach: if a task is preceded by a "-" character, then, do not count the value returned by doLogic.
> See discussion leading to this here:
> http://www.gossamer-threads.com/lists/lucene/java-dev/57081
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1136) add ability to not count sub-task
doLogic increment to contri/benchmark
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561473#action_12561473 ]
Michael McCandless commented on LUCENE-1136:
--------------------------------------------
OK.
> add ability to not count sub-task doLogic increment to contri/benchmark
> -----------------------------------------------------------------------
>
> Key: LUCENE-1136
> URL: https://issues.apache.org/jira/browse/LUCENE-1136
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark
> Reporter: Michael McCandless
> Assignee: Doron Cohen
> Priority: Minor
> Fix For: 2.4
>
> Attachments: lucene-1136.patch, lucene-1136.patch
>
>
> Sometimes, you want to run a sub-task like CloseIndex, and include the time it takes to run, but not include the count that it returns when reporting rec/s.
> We could adopt this approach: if a task is preceded by a "-" character, then, do not count the value returned by doLogic.
> See discussion leading to this here:
> http://www.gossamer-threads.com/lists/lucene/java-dev/57081
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1136) add ability to not count sub-task
doLogic increment to contri/benchmark
Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561470#action_12561470 ]
Doron Cohen commented on LUCENE-1136:
-------------------------------------
As soon as 2.3 is out?
> add ability to not count sub-task doLogic increment to contri/benchmark
> -----------------------------------------------------------------------
>
> Key: LUCENE-1136
> URL: https://issues.apache.org/jira/browse/LUCENE-1136
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark
> Reporter: Michael McCandless
> Assignee: Doron Cohen
> Priority: Minor
> Fix For: 2.4
>
> Attachments: lucene-1136.patch, lucene-1136.patch
>
>
> Sometimes, you want to run a sub-task like CloseIndex, and include the time it takes to run, but not include the count that it returns when reporting rec/s.
> We could adopt this approach: if a task is preceded by a "-" character, then, do not count the value returned by doLogic.
> See discussion leading to this here:
> http://www.gossamer-threads.com/lists/lucene/java-dev/57081
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org