You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/10/28 03:49:16 UTC

[GitHub] [apisix] rapiz1 opened a new pull request #5350: feat: Support installation on arch

rapiz1 opened a new pull request #5350:
URL: https://github.com/apache/apisix/pull/5350


   Adopt the installation script so that it can works on archlinux.
   
   Signed-off-by: Yujia Qiao <ra...@gmail.com>
   
   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] rapiz1 commented on pull request #5350: feat: Support installation on arch

Posted by GitBox <gi...@apache.org>.
rapiz1 commented on pull request #5350:
URL: https://github.com/apache/apisix/pull/5350#issuecomment-953738185


   I've thinked about it but failed to come up with a comprehensive method to test. In fact, the function itself is not exhaustive about all possible aur helpers. But you do remind me that the function could be more robust, like if not finding an aur helper, emit an error and hints.
   
   
   
   ---Original---
   From: "Alex ***@***.***&gt;
   Date: Thu, Oct 28, 2021 18:40 PM
   To: ***@***.***&gt;;
   Cc: "Yujia ***@***.******@***.***&gt;;
   Subject: Re: [apache/apisix] feat: Support installation on arch (PR #5350)
   
   
   
   
    
   @tokers commented on this pull request.
    
   nit comment.
   
    
   In utils/install-dependencies.sh:
    &gt; @@ -19,6 +19,26 @@    set -ex   +function detect_aur_helper() { +if [[ $(which yay) ]]; then +AUR_HELPER=yay +elif [[ $(which pacaur) ]]; then +AUR_HELPER=pacaur +fi +} + +function install_dependencies_with_aur() { +detect_aur_helper  
   Shall we have some tests to cover it?
    
   —
   You are receiving this because you authored the thread.
   Reply to this email directly, view it on GitHub, or unsubscribe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander merged pull request #5350: feat: Support installation on arch

Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #5350:
URL: https://github.com/apache/apisix/pull/5350


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] tokers commented on a change in pull request #5350: feat: Support installation on arch

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #5350:
URL: https://github.com/apache/apisix/pull/5350#discussion_r738263154



##########
File path: utils/install-dependencies.sh
##########
@@ -19,6 +19,26 @@
 
 set -ex
 
+function detect_aur_helper() {
+	if [[ $(which yay) ]]; then
+		AUR_HELPER=yay
+	elif [[ $(which pacaur) ]]; then
+		AUR_HELPER=pacaur
+	fi
+}
+
+function install_dependencies_with_aur() {
+	detect_aur_helper

Review comment:
       Shall we have some tests to cover it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] rapiz1 commented on pull request #5350: feat: Support installation on arch

Posted by GitBox <gi...@apache.org>.
rapiz1 commented on pull request #5350:
URL: https://github.com/apache/apisix/pull/5350#issuecomment-954601608


   > We should also update install-dependencies.md to claim that Arch Linux is supported?
   
   I think so.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #5350: feat: Support installation on arch

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5350:
URL: https://github.com/apache/apisix/pull/5350#discussion_r738300889



##########
File path: utils/install-dependencies.sh
##########
@@ -19,6 +19,26 @@
 
 set -ex
 
+function detect_aur_helper() {
+	if [[ $(which yay) ]]; then
+		AUR_HELPER=yay
+	elif [[ $(which pacaur) ]]; then
+		AUR_HELPER=pacaur
+	fi
+}
+
+function install_dependencies_with_aur() {
+	detect_aur_helper
+	$AUR_HELPER -S openresty --noconfirm
+	sudo pacman -S openssl --noconfirm
+
+	export OPENRESTY_PREFIX=/opt/openresty
+
+	sudo mkdir $OPENRESTY_PREFIX/openssl

Review comment:
       Use space to indent




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] rapiz1 commented on a change in pull request #5350: feat: Support installation on arch

Posted by GitBox <gi...@apache.org>.
rapiz1 commented on a change in pull request #5350:
URL: https://github.com/apache/apisix/pull/5350#discussion_r738875802



##########
File path: utils/install-dependencies.sh
##########
@@ -19,6 +19,26 @@
 
 set -ex
 
+function detect_aur_helper() {
+	if [[ $(which yay) ]]; then
+		AUR_HELPER=yay
+	elif [[ $(which pacaur) ]]; then
+		AUR_HELPER=pacaur
+	fi
+}
+
+function install_dependencies_with_aur() {
+	detect_aur_helper
+	$AUR_HELPER -S openresty --noconfirm
+	sudo pacman -S openssl --noconfirm
+
+	export OPENRESTY_PREFIX=/opt/openresty
+
+	sudo mkdir $OPENRESTY_PREFIX/openssl

Review comment:
       Fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org