[jira] [Comment Edited] (SOLR-16563) Http2SolrClient should have a defaultCollection setting

["Jason Gerlowski (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686642#comment-17686642 ] 

Jason Gerlowski edited comment on SOLR-16563 at 2/9/23 4:43 PM:
----------------------------------------------------------------

(I missed this at the time because Eric used "{{~jegerlow}} as the tag, which looks like a login I must've created from a now-defunct work email.  Anyone know of a way to delete that login to avoid this sort of thing going forward?)

I'd be on board with any approach that gets us away from having the collection sometimes-but-not-always baked into the baseUrl.  Anything that moves us away from that is (y) in my book.

That said - the 'defaultCollection' option has always struck me as a little odd.  I get that it's a convenience thing so folks don't need to specify the collection on every SolrRequest they construct...but is that really all that onerous?  It's always seemed a bit like a "solution in need of a problem" to me, albeit a small one.  (Though maybe I'm misunderstanding part of the rationale.)

Personally I'd slightly prefer nuking 'defaultCollection' over spreading it elsewhere.  But if I'm alone in that, I think either approach is a big step in the right direction of getting collection names out of the baseUrl!


was (Author: gerlowskija):
(I missed this at the time because Eric used "{{[~jegerlow]}} as the tag, which looks like a login I must've created from a now-defunct work email.  Anyone know of a way to delete that login to avoid this sort of thing going forward?)

I'd be on board with any approach that gets us away from having the collection sometimes-but-not-always baked into the baseUrl.  Anything that moves us away from that is (y) in my book.

That said - the 'defaultCollection' option has always struck me as a little odd.  I get that it's a convenience thing so folks don't need to specify the collection on every SolrRequest they construct...but is that really all that onerous?  It's always seemed a bit like a "solution in need of a problem" to me, albeit a small one.  (Though maybe I'm misunderstanding part of the rationale.)

Personally I'd slightly prefer nuking 'defaultCollection' over spreading it elsewhere.  But if I'm alone in that, I think either approach is a big step in the right direction of getting collection names out of the baseUrl!

> Http2SolrClient should have a defaultCollection setting
> -------------------------------------------------------
>
>                 Key: SOLR-16563
>                 URL: https://issues.apache.org/jira/browse/SOLR-16563
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrJ
>            Reporter: David Smiley
>            Assignee: Eric Pugh
>            Priority: Minor
>
> Similar to CloudSolrClient, Http2SolrClient ought to have a "defaultCollection" setting.  This ought to be used in preference to passing a "baseUrl" with this collection/core embedded into it.  Maybe the builder's constructor should be overloaded to have a baseUrl + defaultCollection pair as well.
> Doing this would make it easier to issue an admin or any other node level command using the same SolrClient instance, just as is possible with CloudSolrClient and EmbeddedSolrServer.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org