You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "garydgregory (via GitHub)" <gi...@apache.org> on 2023/03/14 12:51:11 UTC

[GitHub] [commons-lang] garydgregory commented on a diff in pull request #956: Improve JavaDocs

garydgregory commented on code in PR #956:
URL: https://github.com/apache/commons-lang/pull/956#discussion_r1135493662


##########
src/main/java/org/apache/commons/lang3/BitField.java:
##########
@@ -281,7 +281,7 @@ public byte setByte(final byte holder) {
     }
 
     /**
-     * Sets a boolean BitField.
+     * Sets a {@code boolean} BitField.

Review Comment:
   Hi @arturobernalg 
   In this case, the bit field is a `short`, not a `boolean`, right? It's the bits in the bit field that represent booleans. I think If we are going to touch Javadocs we should make sure they are correct first ;-) See the other setters as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org