You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by ja...@apache.org on 2026/06/02 11:03:43 UTC
(grails-core) 02/04: Correct boot4-disabled integration test blocker comment
This is an automated email from the ASF dual-hosted git repository.
jamesfredley pushed a commit to branch grails8-groovy5-sb4
in repository https://gitbox.apache.org/repos/asf/grails-core.git
commit e24e503e153fdccecdae7187112f922766585cdf
Author: James Fredley <ja...@users.noreply.github.com>
AuthorDate: Mon Jun 1 22:55:35 2026 -0400
Correct boot4-disabled integration test blocker comment
The comment claimed two blockers, but the SiteMesh3/Spring 7 one is bogus:
SiteMesh3 in these grails-test-examples apps is env-gated behind
SITEMESH3_TESTING_ENABLED on both 8.0.x and this branch, and the base runs
these same integrationTests fine on Spring 7. The sole real blocker is the
Groovy 5 indy=false controller-action param-scope bug, which re-running
VariableScopeVisitor does not fix (needs an upstream Groovy change). Document
that accurately and link the standalone reproducer.
Assisted-by: claude-code:claude-4.8-opus
---
gradle/boot4-disabled-integration-test-config.gradle | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/gradle/boot4-disabled-integration-test-config.gradle b/gradle/boot4-disabled-integration-test-config.gradle
index abc8d7844a..b3cc09a20e 100644
--- a/gradle/boot4-disabled-integration-test-config.gradle
+++ b/gradle/boot4-disabled-integration-test-config.gradle
@@ -15,12 +15,13 @@
* limitations under the License.
*/
-// integrationTest is disabled for modules applying this file. Two blockers:
-// - SiteMesh3 decorator/layout is not compatible with Spring Framework 7.
-// - Groovy 5 + indy=false: controller action parameters resolve to propertyMissing
-// on the controller instead of the local, throwing MissingPropertyException after
-// ControllerActionTransformer wraps the method body. Functional tests (indy=true) pass.
-// Re-enable per module once its blocker is resolved.
+// integrationTest is disabled for modules applying this file.
+// Blocker: Groovy 5 + indy=false drops the scope of controller action parameters/locals
+// after ControllerActionTransformer re-parents the body inside a TryCatchStatement, so they
+// resolve to propertyMissing on the controller and throw MissingPropertyException. Re-running
+// VariableScopeVisitor does not rebind them; this needs an upstream Groovy fix. indy=true passes.
+// Reproducer: https://github.com/jamesfredley/groovy5-controller-action-param-scope-bug
+// Re-enable once the upstream fix lands.
tasks.named('integrationTest') {
enabled = false