You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "jayzhan211 (via GitHub)" <gi...@apache.org> on 2025/03/26 12:22:51 UTC
[I] Move `optimize_subquery_sort` into optimizer `EliminateSort` [datafusion]
jayzhan211 opened a new issue, #15435:
URL: https://github.com/apache/datafusion/issues/15435
I have no idea why we have optimize plan rule `optimize_subquery_sort` in `create_relation`, I think we should move such rule to optimizer 🤔
_Originally posted by @jayzhan211 in https://github.com/apache/datafusion/pull/15300#discussion_r2002212215_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Move `optimize_subquery_sort` into optimizer as a new rule `EliminateSort` [datafusion]
Posted by "irenjj (via GitHub)" <gi...@apache.org>.
irenjj commented on issue #15435:
URL: https://github.com/apache/datafusion/issues/15435#issuecomment-2756228364
> > Using `datafusion-optimizer` in `datafusion-sql` can lead to dependency issue:
> > ```
> > thread 'main' panicked at src/main.rs:84:9:
> > circular dependency detected from datafusion-optimizer to self via one of {"datafusion-functions-window", "datafusion-functions-window-common", "datafusion-expr-common", "datafusion-expr", "datafusion-physical-expr", "datafusion-doc", "datafusion-functions-aggregate-common", "datafusion-sql", "datafusion-execution", "datafusion-macros", "datafusion-physical-expr-common", "datafusion-functions-nested", "datafusion-functions", "datafusion-common", "datafusion-functions-aggregate"}
> > ```
>
> You shouldn't call the optimizer in sql, after the plan is built, we will call optimizer to rewrite the plan.
got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Move `optimize_subquery_sort` into optimizer as a new rule `EliminateSort` [datafusion]
Posted by "acking-you (via GitHub)" <gi...@apache.org>.
acking-you commented on issue #15435:
URL: https://github.com/apache/datafusion/issues/15435#issuecomment-2754321068
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Move `optimize_subquery_sort` into optimizer as a new rule `EliminateSort` [datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 commented on issue #15435:
URL: https://github.com/apache/datafusion/issues/15435#issuecomment-2756154926
> Using `datafusion-optimizer` in `datafusion-sql` can lead to dependency issue:
>
> ```
> thread 'main' panicked at src/main.rs:84:9:
> circular dependency detected from datafusion-optimizer to self via one of {"datafusion-functions-window", "datafusion-functions-window-common", "datafusion-expr-common", "datafusion-expr", "datafusion-physical-expr", "datafusion-doc", "datafusion-functions-aggregate-common", "datafusion-sql", "datafusion-execution", "datafusion-macros", "datafusion-physical-expr-common", "datafusion-functions-nested", "datafusion-functions", "datafusion-common", "datafusion-functions-aggregate"}
> ```
You shouldn't call the optimizer in sql, after the plan is built, we will call optimizer to rewrite the plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Move `optimize_subquery_sort` into optimizer as a new rule `EliminateSort` [datafusion]
Posted by "irenjj (via GitHub)" <gi...@apache.org>.
irenjj commented on issue #15435:
URL: https://github.com/apache/datafusion/issues/15435#issuecomment-2754833600
Using `datafusion-optimizer` in `datafusion-sql` can lead to dependency issue:
```
thread 'main' panicked at src/main.rs:84:9:
circular dependency detected from datafusion-optimizer to self via one of {"datafusion-functions-window", "datafusion-functions-window-common", "datafusion-expr-common", "datafusion-expr", "datafusion-physical-expr", "datafusion-doc", "datafusion-functions-aggregate-common", "datafusion-sql", "datafusion-execution", "datafusion-macros", "datafusion-physical-expr-common", "datafusion-functions-nested", "datafusion-functions", "datafusion-common", "datafusion-functions-aggregate"}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org