You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asyncband.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2026/09/04 04:26:44 UTC
[PR] fix: correct derived source license headers [asyncband]
tisonkun opened a new pull request, #277:
URL: https://github.com/apache/asyncband/pull/277
## Summary
- remove the ASF header from the directly adapted private parker and exclude that exact file from Hawkeye's ASF-header check
- retain ASF headers on files with major Asyncband modifications while describing the incorporated upstream code as scoped portions
- correct OneShot test provenance to reference the actual upstream test suite and include its shared support file
## Design Notes
The review compared the current files with the pinned Tokio, futures-rs, oneshot, Pollster, futures-lite, parking, and Fastpool commits recorded in `LICENSE` and `HISTORY.md`.
`blocking/parker.rs` closely adapts parking's private state machine, so it is treated as third-party source and does not carry the ASF header. `blocking/mod.rs` retains the header because only its polling and cache patterns are adapted. AtomicWaker, Mutex/RwLock, OneShot, and Pool retain the header because their current files contain major Asyncband implementation, API, safety, or lifecycle changes; their provenance notices now describe only the incorporated portions.
The private OneShot `AWAKING` regression tests are Asyncband-specific. Only their support lineage is attributed upstream, while the integration tests link to the actual upstream async, future, Miri, sync, and helper sources at the pinned commit.
## Validation
- `cargo +nightly clippy --tests --all-features --all-targets --workspace -- -D warnings`
- `cargo +nightly fmt --all --check`
- `hawkeye check`
- `typos`
- `RUSTDOCFLAGS='-D warnings --cfg docsrs' cargo +nightly doc --workspace --all-features --no-deps`
- `cargo x test`
- `cargo package --package asyncband --locked --list --allow-dirty`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org
For additional commands, e-mail: commits-help@asyncband.apache.org
Re: [PR] fix: correct derived source license headers [asyncband]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun closed pull request #277: fix: correct derived source license headers
URL: https://github.com/apache/asyncband/pull/277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org
For additional commands, e-mail: commits-help@asyncband.apache.org
Re: [PR] fix: correct derived source license headers [asyncband]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #277:
URL: https://github.com/apache/asyncband/pull/277#issuecomment-5536029121
This is included in https://github.com/apache/asyncband/pull/278.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org
For additional commands, e-mail: commits-help@asyncband.apache.org