[jira] [Resolved] (SCXML-168) Test failure in SCXMLWriterTest using Java 7

["Ate Douma (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SCXML-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ate Douma resolved SCXML-168.
-----------------------------

    Resolution: Fixed

Patch applied (myself)

> Test failure in SCXMLWriterTest using Java 7
> --------------------------------------------
>
>                 Key: SCXML-168
>                 URL: https://issues.apache.org/jira/browse/SCXML-168
>             Project: Commons SCXML
>          Issue Type: Bug
>    Affects Versions: 1.0
>         Environment: Oracle Java 1.7.0_40-b43
>            Reporter: Ate Douma
>            Assignee: Ate Douma
>             Fix For: 1.0
>
>         Attachments: SCXML-168.patch
>
>
> Tests in the SCXMLWriterTest use StaX to transform SCXML to a pretty printed output and then compare this to a predefined expected output.
> However this is not reliable across Java compilers as to how pretty printing is precisely done. 
> In this case, with (Oracle) Java 6, a newline is inserted between the XML declaration and the root element, while on (Oracle) Java 7 no such newline is added. As result these tests fail with Java 7. 
> For these tests I think it is easy to fix: there is no functional need (here) to compare the XML output pretty formatted, so I simply removed the pretty printing and adjusted the predefined String to compare against.
> I'll attach a patch file shortly.



--
This message was sent by Atlassian JIRA
(v6.1#6144)