[GitHub] [hbase] wchevreuil commented on a change in pull request #1668: HBASE-24335 Support deleteall with ts but without column in shell mode

[GitBox <gi...@apache.org>]

wchevreuil commented on a change in pull request #1668:
URL: https://github.com/apache/hbase/pull/1668#discussion_r420865627



##########
File path: hbase-shell/src/main/ruby/shell/commands/deleteall.rb
##########
@@ -30,12 +30,14 @@ def help
   hbase> deleteall 't1', 'r1'
   hbase> deleteall 't1', 'r1', 'c1'
   hbase> deleteall 't1', 'r1', 'c1', ts1
+  hbase> deleteall 't1', 'r1', '', ts1        //'' means not specify column

Review comment:
       nit: better rephrase comment as: `//'' means no specific column`

##########
File path: hbase-shell/src/main/ruby/shell/commands/deleteall.rb
##########
@@ -30,12 +30,14 @@ def help
   hbase> deleteall 't1', 'r1'
   hbase> deleteall 't1', 'r1', 'c1'
   hbase> deleteall 't1', 'r1', 'c1', ts1
+  hbase> deleteall 't1', 'r1', '', ts1        //'' means not specify column

Review comment:
       Maybe worth also explain that this command deletes all cells in the row which timestamp is lower than the one specified in the command.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org