You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/21 17:05:19 UTC

[GitHub] [airflow] robinedwards commented on a change in pull request #7232: [AIRFLOW-6569] Flush pending Sentry exceptions before exiting forked process

robinedwards commented on a change in pull request #7232: [AIRFLOW-6569] Flush pending Sentry exceptions before exiting forked process
URL: https://github.com/apache/airflow/pull/7232#discussion_r369128268
 
 

 ##########
 File path: airflow/task/task_runner/standard_task_runner.py
 ##########
 @@ -82,6 +83,8 @@ def _start_by_fork(self):
                 args.func(args, dag=self.dag)
 
 Review comment:
   Just wondering if we should flush() here too. If there are any calls to logger.error() in the task in this case I dont think they will get sent?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services