You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/12/31 02:49:47 UTC
[GitHub] [incubator-kyuubi] yaooqinn edited a comment on pull request #1658: Revamp swagger ui dependencies
yaooqinn edited a comment on pull request #1658:
URL: https://github.com/apache/incubator-kyuubi/pull/1658#issuecomment-1003247115
> ```json
> components
> ```
> Sorry for the later review, @yaooqinn
>
> > This PR mainly removes the swagger-scala-module which is currently fine to remove.
>
> This is a breaking change for openapi. `swagger-scala-module` is a library that automatically generates a schema from a Scala case class.
>
> After this PR
>
> ```json
> "components" : {
> "schemas" : {
> "OpActionRequest" : {
> "type" : "object"
> },
> "KyuubiOperationEvent" : {
> "type" : "object"
> },
> "OperationLog" : {
> "type" : "object"
> },
> "ResultSetMetaData" : {
> "type" : "object"
> },
> "OperationHandle" : {
> "type" : "object",
> "properties" : {
> "hasResultSet" : {
> "type" : "boolean",
> "writeOnly" : true
> }
> }
> },
> "ExecPoolStatistic" : {
> "type" : "object"
> },
> "StatementRequest" : {
> "type" : "object"
> },
> "GetColumnsRequest" : {
> "type" : "object"
> },
> "GetFunctionsRequest" : {
> "type" : "object"
> },
> "InfoDetail" : {
> "type" : "object"
> },
> "GetSchemasRequest" : {
> "type" : "object"
> },
> "GetTablesRequest" : {
> "type" : "object"
> },
> "SessionHandle" : {
> "type" : "object"
> },
> "SessionOpenRequest" : {
> "type" : "object"
> },
> "SessionOpenCount" : {
> "type" : "object"
> },
> "KyuubiSessionEvent" : {
> "type" : "object"
> },
> "SessionList" : {
> "type" : "object"
> }
> }
> }
> ```
>
> Before this PR
>
> ```json
> "components" : {
> "schemas" : {
> "OpActionRequest" : {
> "required" : [ "action" ],
> "type" : "object",
> "properties" : {
> "action" : {
> "type" : "string"
> }
> }
> },
> "KyuubiOperationEvent" : {
> "required" : [ "eventTime", "shouldRunAsync", "statementId" ],
> "type" : "object",
> "properties" : {
> "statementId" : {
> "type" : "string"
> },
> "remoteId" : {
> "type" : "string"
> },
> "statement" : {
> "type" : "string"
> },
> "shouldRunAsync" : {
> "type" : "boolean"
> },
> "state" : {
> "type" : "string"
> },
> "eventTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "createTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "startTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "completeTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "exception" : {
> "type" : "object",
> "properties" : {
> "cause" : {
> "required" : [ "stackTrace", "suppressed" ],
> "type" : "object",
> "properties" : {
> "stackTrace" : {
> "type" : "array",
> "items" : {
> "required" : [ "lineNumber" ],
> "type" : "object",
> "properties" : {
> "methodName" : {
> "type" : "string"
> },
> "fileName" : {
> "type" : "string"
> },
> "lineNumber" : {
> "type" : "integer",
> "format" : "int32"
> },
> "className" : {
> "type" : "string"
> },
> "nativeMethod" : {
> "type" : "boolean"
> }
> }
> }
> },
> "message" : {
> "type" : "string"
> },
> "localizedMessage" : {
> "type" : "string"
> },
> "suppressed" : {
> "type" : "array",
> "items" : {
> "type" : "object",
> "properties" : {
> "stackTrace" : {
> "type" : "array",
> "items" : {
> "required" : [ "lineNumber" ],
> "type" : "object",
> "properties" : {
> "methodName" : {
> "type" : "string"
> },
> "fileName" : {
> "type" : "string"
> },
> "lineNumber" : {
> "type" : "integer",
> "format" : "int32"
> },
> "className" : {
> "type" : "string"
> },
> "nativeMethod" : {
> "type" : "boolean"
> }
> }
> }
> },
> "message" : {
> "type" : "string"
> },
> "localizedMessage" : {
> "type" : "string"
> }
> }
> }
> }
> }
> },
> "stackTrace" : {
> "type" : "array",
> "items" : {
> "required" : [ "lineNumber" ],
> "type" : "object",
> "properties" : {
> "methodName" : {
> "type" : "string"
> },
> "fileName" : {
> "type" : "string"
> },
> "lineNumber" : {
> "type" : "integer",
> "format" : "int32"
> },
> "className" : {
> "type" : "string"
> },
> "nativeMethod" : {
> "type" : "boolean"
> }
> }
> }
> },
> "message" : {
> "type" : "string"
> },
> "localizedMessage" : {
> "type" : "string"
> },
> "suppressed" : {
> "type" : "array",
> "items" : {
> "type" : "object",
> "properties" : {
> "stackTrace" : {
> "type" : "array",
> "items" : {
> "required" : [ "lineNumber" ],
> "type" : "object",
> "properties" : {
> "methodName" : {
> "type" : "string"
> },
> "fileName" : {
> "type" : "string"
> },
> "lineNumber" : {
> "type" : "integer",
> "format" : "int32"
> },
> "className" : {
> "type" : "string"
> },
> "nativeMethod" : {
> "type" : "boolean"
> }
> }
> }
> },
> "message" : {
> "type" : "string"
> },
> "localizedMessage" : {
> "type" : "string"
> }
> }
> }
> }
> }
> },
> "sessionId" : {
> "type" : "string"
> },
> "sessionUser" : {
> "type" : "string"
> },
> "eventType" : {
> "type" : "string"
> }
> }
> },
> "OperationLog" : {
> "required" : [ "logRowSet", "rowCount" ],
> "type" : "object",
> "properties" : {
> "logRowSet" : {
> "type" : "array",
> "items" : {
> "type" : "string"
> }
> },
> "rowCount" : {
> "type" : "integer",
> "format" : "int32"
> }
> }
> },
> "SeqString" : {
> "type" : "array",
> "items" : {
> "type" : "string"
> }
> },
> "ColumnDesc" : {
> "required" : [ "columnIndex", "columnName" ],
> "type" : "object",
> "properties" : {
> "columnName" : {
> "type" : "string"
> },
> "dataType" : {
> "type" : "string"
> },
> "columnIndex" : {
> "type" : "integer",
> "format" : "int32"
> },
> "precision" : {
> "type" : "integer",
> "format" : "int32"
> },
> "scale" : {
> "type" : "integer",
> "format" : "int32"
> },
> "comment" : {
> "type" : "string"
> }
> }
> },
> "ResultSetMetaData" : {
> "required" : [ "columns" ],
> "type" : "object",
> "properties" : {
> "columns" : {
> "type" : "array",
> "items" : {
> "$ref" : "#/components/schemas/ColumnDesc"
> }
> }
> }
> },
> "SeqColumnDesc" : {
> "type" : "array",
> "items" : {
> "$ref" : "#/components/schemas/ColumnDesc"
> }
> },
> "HandleIdentifier" : {
> "required" : [ "publicId" ],
> "type" : "object",
> "properties" : {
> "publicId" : {
> "type" : "string",
> "format" : "uuid"
> },
> "secretId" : {
> "type" : "string",
> "format" : "uuid"
> }
> }
> },
> "OperationHandle" : {
> "required" : [ "hasResultSet", "identifier", "protocol", "typ" ],
> "type" : "object",
> "properties" : {
> "identifier" : {
> "$ref" : "#/components/schemas/HandleIdentifier"
> },
> "typ" : {
> "$ref" : "#/components/schemas/Value"
> },
> "protocol" : {
> "type" : "string",
> "enum" : [ "HIVE_CLI_SERVICE_PROTOCOL_V1", "HIVE_CLI_SERVICE_PROTOCOL_V2", "HIVE_CLI_SERVICE_PROTOCOL_V3", "HIVE_CLI_SERVICE_PROTOCOL_V4", "HIVE_CLI_SERVICE_PROTOCOL_V5", "HIVE_CLI_SERVICE_PROTOCOL_V6", "HIVE_CLI_SERVICE_PROTOCOL_V7", "HIVE_CLI_SERVICE_PROTOCOL_V8", "HIVE_CLI_SERVICE_PROTOCOL_V9", "HIVE_CLI_SERVICE_PROTOCOL_V10" ]
> },
> "hasResultSet" : {
> "type" : "boolean",
> "writeOnly" : true
> }
> }
> },
> "Value" : {
> "type" : "object"
> },
> "ExecPoolStatistic" : {
> "required" : [ "execPoolSize" ],
> "type" : "object",
> "properties" : {
> "execPoolSize" : {
> "type" : "integer",
> "format" : "int32"
> },
> "execPoolActiveCount" : {
> "type" : "integer",
> "format" : "int32"
> }
> }
> },
> "StatementRequest" : {
> "required" : [ "queryTimeout", "runAsync", "statement" ],
> "type" : "object",
> "properties" : {
> "statement" : {
> "type" : "string"
> },
> "runAsync" : {
> "type" : "boolean"
> },
> "queryTimeout" : {
> "type" : "integer",
> "format" : "int64"
> }
> }
> },
> "GetColumnsRequest" : {
> "required" : [ "catalogName" ],
> "type" : "object",
> "properties" : {
> "catalogName" : {
> "type" : "string"
> },
> "schemaName" : {
> "type" : "string"
> },
> "tableName" : {
> "type" : "string"
> },
> "columnName" : {
> "type" : "string"
> }
> }
> },
> "GetFunctionsRequest" : {
> "required" : [ "catalogName" ],
> "type" : "object",
> "properties" : {
> "catalogName" : {
> "type" : "string"
> },
> "schemaName" : {
> "type" : "string"
> },
> "functionName" : {
> "type" : "string"
> }
> }
> },
> "InfoDetail" : {
> "required" : [ "infoType" ],
> "type" : "object",
> "properties" : {
> "infoType" : {
> "type" : "string"
> },
> "infoValue" : {
> "type" : "string"
> }
> }
> },
> "GetSchemasRequest" : {
> "required" : [ "catalogName" ],
> "type" : "object",
> "properties" : {
> "catalogName" : {
> "type" : "string"
> },
> "schemaName" : {
> "type" : "string"
> }
> }
> },
> "GetTablesRequest" : {
> "required" : [ "catalogName", "tableTypes" ],
> "type" : "object",
> "properties" : {
> "catalogName" : {
> "type" : "string"
> },
> "schemaName" : {
> "type" : "string"
> },
> "tableName" : {
> "type" : "string"
> },
> "tableTypes" : {
> "type" : "array",
> "items" : {
> "type" : "string"
> }
> }
> }
> },
> "SessionHandle" : {
> "required" : [ "identifier", "protocol" ],
> "type" : "object",
> "properties" : {
> "identifier" : {
> "$ref" : "#/components/schemas/HandleIdentifier"
> },
> "protocol" : {
> "type" : "string",
> "enum" : [ "HIVE_CLI_SERVICE_PROTOCOL_V1", "HIVE_CLI_SERVICE_PROTOCOL_V2", "HIVE_CLI_SERVICE_PROTOCOL_V3", "HIVE_CLI_SERVICE_PROTOCOL_V4", "HIVE_CLI_SERVICE_PROTOCOL_V5", "HIVE_CLI_SERVICE_PROTOCOL_V6", "HIVE_CLI_SERVICE_PROTOCOL_V7", "HIVE_CLI_SERVICE_PROTOCOL_V8", "HIVE_CLI_SERVICE_PROTOCOL_V9", "HIVE_CLI_SERVICE_PROTOCOL_V10" ]
> }
> }
> },
> "MapStringString" : {
> "type" : "object",
> "additionalProperties" : {
> "type" : "string"
> }
> },
> "SessionOpenRequest" : {
> "required" : [ "configs", "protocolVersion", "user" ],
> "type" : "object",
> "properties" : {
> "protocolVersion" : {
> "type" : "integer",
> "format" : "int32"
> },
> "user" : {
> "type" : "string"
> },
> "password" : {
> "type" : "string"
> },
> "ipAddr" : {
> "type" : "string"
> },
> "configs" : {
> "type" : "object",
> "additionalProperties" : {
> "type" : "string"
> }
> }
> }
> },
> "SessionOpenCount" : {
> "required" : [ "openSessionCount" ],
> "type" : "object",
> "properties" : {
> "openSessionCount" : {
> "type" : "integer",
> "format" : "int32"
> }
> }
> },
> "KyuubiSessionEvent" : {
> "required" : [ "clientVersion", "conf", "sessionId", "startTime" ],
> "type" : "object",
> "properties" : {
> "sessionId" : {
> "type" : "string"
> },
> "clientVersion" : {
> "type" : "integer",
> "format" : "int32"
> },
> "sessionName" : {
> "type" : "string"
> },
> "user" : {
> "type" : "string"
> },
> "clientIP" : {
> "type" : "string"
> },
> "serverIP" : {
> "type" : "string"
> },
> "conf" : {
> "type" : "object",
> "additionalProperties" : {
> "type" : "string"
> }
> },
> "startTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "remoteSessionId" : {
> "type" : "string"
> },
> "engineId" : {
> "type" : "string"
> },
> "openedTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "endTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "totalOperations" : {
> "type" : "integer",
> "format" : "int32"
> },
> "eventType" : {
> "type" : "string"
> }
> }
> },
> "SeqSessionOverview" : {
> "type" : "array",
> "items" : {
> "$ref" : "#/components/schemas/SessionOverview"
> }
> },
> "SessionList" : {
> "required" : [ "sessionList" ],
> "type" : "object",
> "properties" : {
> "sessionList" : {
> "type" : "array",
> "items" : {
> "$ref" : "#/components/schemas/SessionOverview"
> }
> }
> }
> },
> "SessionOverview" : {
> "required" : [ "createTime", "user" ],
> "type" : "object",
> "properties" : {
> "user" : {
> "type" : "string"
> },
> "ipAddr" : {
> "type" : "string"
> },
> "createTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "sessionHandle" : {
> "$ref" : "#/components/schemas/SessionHandle"
> }
> }
> }
> }
> }
> ```
can we inline some logic for that, that module seems one have one class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org