[GitHub] [arrow-datafusion] Dandandan edited a comment on issue #843: Incorrect results for joins on hash collisions

[GitBox <gi...@apache.org>]

Dandandan edited a comment on issue #843:
URL: https://github.com/apache/arrow-datafusion/issues/843#issuecomment-895315439


   Interesting approach! I will look at this later to solve it if you don't beat me to it.
   
   Based on the test output I think a bug triggers with handling of NULL values.
   
   ```
           match (left_array.is_null($left), left_array.is_null($right)) {
               (false, false) => left_array.value($left) == right_array.value($right),
               _ => false,
           }
   ```
   This looks suspicious, at least this should be `right_array` for the second value. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org