[GitHub] Fokko commented on a change in pull request #3710: [AIRFLOW-2860] Update tests for druid hook

[GitBox <gi...@apache.org>]

Fokko commented on a change in pull request #3710: [AIRFLOW-2860] Update tests for druid hook
URL: https://github.com/apache/incubator-airflow/pull/3710#discussion_r208008753
 
 

 ##########
 File path: airflow/hooks/druid_hook.py
 ##########
 @@ -53,6 +54,8 @@ def __init__(
         self.max_ingestion_time = max_ingestion_time
         self.header = {'content-type': 'application/json'}
 
+        assert self.timeout >= 1
 
 Review comment:
   @awelsh93 
   Can you change this line to:
   ```
   if self.timeout < 1:
      raise ValueError("Druid timeout should be equal or greater than 1")
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services