You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by cwelton <gi...@git.apache.org> on 2016/08/02 17:49:26 UTC
[GitHub] incubator-quickstep pull request #75: QUICKSTEP-38. Add support for python3 ...
GitHub user cwelton opened a pull request:
https://github.com/apache/incubator-quickstep/pull/75
QUICKSTEP-38. Add support for python3 to utility scripts
Three core changes:
- update from python2 print command, to python3 print function [1]
- switch from xrange to range [1]
- switch from dict.iteritems to iter(dict.items()) [2]
[1] http://python-future.org/compatible_idioms.html
[2] http://legacy.python.org/dev/peps/pep-0469/
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cwelton/incubator-quickstep master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/75.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #75
----
commit 1c48650e21f7fa0fb7c0dda2b08512618cdc8c07
Author: Caleb Welton <cw...@apache.org>
Date: 2016-08-02T17:44:41Z
QUICKSTEP-38. Add support for python3 to utility scripts
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...
Posted by cwelton <gi...@git.apache.org>.
Github user cwelton commented on the issue:
https://github.com/apache/incubator-quickstep/pull/75
Rebase complete
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/75
@cwelton No worry for this PR. I've addressed the issues in the `master` branch. Thanks again for submitting a PR.
Next time if we run `git fetch origin/master` and then `git rebase -i origin/master`, I think we are good to go.
Cheers!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...
Posted by cwelton <gi...@git.apache.org>.
Github user cwelton commented on the issue:
https://github.com/apache/incubator-quickstep/pull/75
Thanks for fixing, I suggest adding a contributor's guide with your suggested git workflow, to help streamline future contributors/contributions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...
Posted by pateljm <gi...@git.apache.org>.
Github user pateljm commented on the issue:
https://github.com/apache/incubator-quickstep/pull/75
Thanks @cwelton! Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/75
Yes, we should add a workflow for contributors as well. Stay tuned!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...
Posted by cwelton <gi...@git.apache.org>.
Github user cwelton commented on the issue:
https://github.com/apache/incubator-quickstep/pull/75
Ah, sorry, just thought you wanted the extraneous merge commit squashed. I've reordered the commits in my branch. For some reason the hashjoin commit is still showing up in this PR, not sure why.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #75: QUICKSTEP-38. Add support for python3 ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/75
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/75
@pateljm We need to reverse this merge, due to an incorrect rebase.
@cwelton We expect a different rebase result where this PR only contains a single commit ahead of the `origin/master`, instead of having another unrelated commit from a merged PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...
Posted by pateljm <gi...@git.apache.org>.
Github user pateljm commented on the issue:
https://github.com/apache/incubator-quickstep/pull/75
This looks good Caleb (@cwelton)! Can you rebase so that I can merge this commit? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/75
@cwelton I've created [the guideline](https://cwiki.apache.org/confluence/display/QUICKSTEP/Workflow+For+Contributors) as suggested. Cheers!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---