You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shawn Heisey (JIRA)" <ji...@apache.org> on 2015/06/10 17:46:00 UTC
[jira] [Commented] (SOLR-7659)
DirectoryFileStream.releaseCommitPointAndExtendReserve -- should it extend
first?
[ https://issues.apache.org/jira/browse/SOLR-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580669#comment-14580669 ]
Shawn Heisey commented on SOLR-7659:
------------------------------------
It's not completely necessary to rename the method, but it seemed like a good thing to do based on changing what the code does. Within the Solr source, it is only used locally, and the number of users that are likely to write code extending the class should be very low.
> DirectoryFileStream.releaseCommitPointAndExtendReserve -- should it extend first?
> ---------------------------------------------------------------------------------
>
> Key: SOLR-7659
> URL: https://issues.apache.org/jira/browse/SOLR-7659
> Project: Solr
> Issue Type: Improvement
> Components: replication (java)
> Affects Versions: 5.2.1
> Reporter: Shawn Heisey
> Priority: Minor
> Fix For: 5.3, Trunk
>
> Attachments: SOLR-7659.patch
>
>
> After a misunderstanding on my part, leading to an incorrect documentation edit, [~shalinmangar] helped me understand how the commit reserve duration works.
> The resulting discussion on the dev list brought up a possible problem in ReplicationHandler. We wondered whether it might be possible for another thread to sneak in a commit point deletion in between the two statements found in the releaseCommitPointAndExtendReserve method on the DirectoryFileStream object. If it is safe to do so, I propose reversing those two statements so the reserve extension is done before releasing the commit point.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org