[GitHub] [hbase] bbeaudreault edited a comment on pull request #4163: HBASE-26784 Use HIGH_QOS for ResultScanner.close requests

[GitBox <gi...@apache.org>]

bbeaudreault edited a comment on pull request #4163:
URL: https://github.com/apache/hbase/pull/4163#issuecomment-1059579119


   The remaining checkstyle warnings are all ImportOrder, which are hard to understand. The imports look properly sorted to me.
   
   Looking at our checkstyle.xml, I see there are some groups defined so I figured maybe it was that. But we don't have `separated=true`, and these are already grouped together.  I tried search the codebase for examples of, for example one of my violations, `org.junit.Before`, and couldn't find any way in which my imports are different from those.
   
   I tried running mvn checkstyle:check locally, but it failed to run at all. Without that it'd be hard to iterate on this using the CI to check my ordering, so if someone has guidance I'd be happy to make changes. Otherwise I'll just leave that as is.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org