[GitHub] [calcite] amaliujia commented on a change in pull request #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR

[GitBox <gi...@apache.org>]

amaliujia commented on a change in pull request #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#discussion_r353987008
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java
 ##########
 @@ -2455,7 +2455,13 @@ protected void convertCollectionTable(
     }
 
     RexNode rexCall = bb.convertExpression(call);
-    final List<RelNode> inputs = bb.retrieveCursors();
+    List<RelNode> inputs = new ArrayList<>();
+
+    if (rexCall.getKind() == SqlKind.TUMBLE) {
 
 Review comment:
   @julianhyde do you have more comments regarding to this line of change?
   
   Also generally I will try to push this change into 1.22.0 release. Could you let me know if there are other big refactors that I can do so I can do them soon?
   
   Or if you think it is less mature to let this change into 1.22.0, please let me know and it's ok. I will work toward to make it released in 1.23.0

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services