You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "James William Dumay (JIRA)" <ji...@codehaus.org> on 2008/06/16 02:22:12 UTC

[jira] Created: (WAGON-220) Wagon HTTP Deadlocks under high load

Wagon HTTP Deadlocks under high load
------------------------------------

                 Key: WAGON-220
                 URL: http://jira.codehaus.org/browse/WAGON-220
             Project: Maven Wagon
          Issue Type: Bug
          Components: wagon-http
    Affects Versions: 1.0-beta-3
            Reporter: James William Dumay
         Attachments: 06130051-maven.txt, maven.atlassian.com-log-20080612.txt, maven.atlassian.com-threaddump-20080612_20:17.txt

It seems that the MultiThreadedHttpConnectionManager deadlocks under high load.

See the attached thread dumps from Archiva for more information. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (WAGON-220) Wagon HTTP Deadlocks under high load

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/WAGON-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=180965#action_180965 ] 

John Casey commented on WAGON-220:
----------------------------------

Is this still an issue? I've added cleanupGetTransfer to the catch blocks of getInputStream(..) on the StreamWagon, to avoid problems there, but I'm not sure about releasing the connection from the get method just before we actually start reading from the InputStream resulting from that GET...not sure what the implications are for the connection maintenance, etc.

> Wagon HTTP Deadlocks under high load
> ------------------------------------
>
>                 Key: WAGON-220
>                 URL: http://jira.codehaus.org/browse/WAGON-220
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-http
>    Affects Versions: 1.0-beta-3
>            Reporter: James William Dumay
>             Fix For: 1.0
>
>         Attachments: 06130051-maven.txt, maven.atlassian.com-log-20080612.txt, maven.atlassian.com-threaddump-20080612_20:17.txt, WAGON-220.patch
>
>
> It seems that the MultiThreadedHttpConnectionManager deadlocks under high load.
> See the attached thread dumps from Archiva for more information. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (WAGON-220) Wagon HTTP Deadlocks under high load

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/WAGON-220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated WAGON-220:
-------------------------------

    Fix Version/s: 1.0

> Wagon HTTP Deadlocks under high load
> ------------------------------------
>
>                 Key: WAGON-220
>                 URL: http://jira.codehaus.org/browse/WAGON-220
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-http
>    Affects Versions: 1.0-beta-3
>            Reporter: James William Dumay
>             Fix For: 1.0
>
>         Attachments: 06130051-maven.txt, maven.atlassian.com-log-20080612.txt, maven.atlassian.com-threaddump-20080612_20:17.txt, WAGON-220.patch
>
>
> It seems that the MultiThreadedHttpConnectionManager deadlocks under high load.
> See the attached thread dumps from Archiva for more information. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (WAGON-220) Wagon HTTP Deadlocks under high load

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/WAGON-220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated WAGON-220:
-------------------------------

    Fix Version/s:     (was: 1.0-beta-5)
                   1.0

> Wagon HTTP Deadlocks under high load
> ------------------------------------
>
>                 Key: WAGON-220
>                 URL: http://jira.codehaus.org/browse/WAGON-220
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-http
>    Affects Versions: 1.0-beta-3
>            Reporter: James William Dumay
>             Fix For: 1.0
>
>         Attachments: 06130051-maven.txt, maven.atlassian.com-log-20080612.txt, maven.atlassian.com-threaddump-20080612_20:17.txt, WAGON-220.patch
>
>
> It seems that the MultiThreadedHttpConnectionManager deadlocks under high load.
> See the attached thread dumps from Archiva for more information. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (WAGON-220) Wagon HTTP Deadlocks under high load

Posted by "James William Dumay (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/WAGON-220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James William Dumay updated WAGON-220:
--------------------------------------

    Attachment: WAGON-220.patch

Initial patch. This releases the connection for the GetMethod back into the pool.

We should have some tests for the connection releasing.

> Wagon HTTP Deadlocks under high load
> ------------------------------------
>
>                 Key: WAGON-220
>                 URL: http://jira.codehaus.org/browse/WAGON-220
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-http
>    Affects Versions: 1.0-beta-3
>            Reporter: James William Dumay
>         Attachments: 06130051-maven.txt, maven.atlassian.com-log-20080612.txt, maven.atlassian.com-threaddump-20080612_20:17.txt, WAGON-220.patch
>
>
> It seems that the MultiThreadedHttpConnectionManager deadlocks under high load.
> See the attached thread dumps from Archiva for more information. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (WAGON-220) Wagon HTTP Deadlocks under high load

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/WAGON-220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Casey closed WAGON-220.
----------------------------

         Assignee: John Casey
       Resolution: Fixed
    Fix Version/s:     (was: 1.0)
                   1.0-beta-6

I've added code to ensure the current get method instance releases its connection when an error occurs, but I'm not sure of the wisdom of releasing the connection before reading from the method's response body...I simply don't know the internals of httpclient that well.

I'm closing this based on the code I added...if it's still an issue, reopen it and we should start from a failing test case.

> Wagon HTTP Deadlocks under high load
> ------------------------------------
>
>                 Key: WAGON-220
>                 URL: http://jira.codehaus.org/browse/WAGON-220
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-http
>    Affects Versions: 1.0-beta-3
>            Reporter: James William Dumay
>            Assignee: John Casey
>             Fix For: 1.0-beta-6
>
>         Attachments: 06130051-maven.txt, maven.atlassian.com-log-20080612.txt, maven.atlassian.com-threaddump-20080612_20:17.txt, WAGON-220.patch
>
>
> It seems that the MultiThreadedHttpConnectionManager deadlocks under high load.
> See the attached thread dumps from Archiva for more information. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira