You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/26 08:40:15 UTC
[GitHub] [arrow] raulcd opened a new pull request, #13708: ARROW-17025: [Dev][Release] Merge script should prompt for next version when maintenance branch is created
raulcd opened a new pull request, #13708:
URL: https://github.com/apache/arrow/pull/13708
Currently the merge_pr script is asking to merge to 9.0.0 when the fetature freeze has been implemented. If the maintenance branch is created we should filter them from the possible versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13708: ARROW-17025: [Dev][Release] Merge script should prompt for next version when maintenance branch is created
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13708:
URL: https://github.com/apache/arrow/pull/13708#issuecomment-1195184216
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13708: ARROW-17205: [Dev][Release] Merge script should prompt for next version when maintenance branch is created
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13708:
URL: https://github.com/apache/arrow/pull/13708#issuecomment-1195191142
https://issues.apache.org/jira/browse/ARROW-17205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13708: ARROW-17025: [Dev][Release] Merge script should prompt for next version when maintenance branch is created
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13708:
URL: https://github.com/apache/arrow/pull/13708#issuecomment-1195184187
https://issues.apache.org/jira/browse/ARROW-17025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #13708: ARROW-17205: [Dev][Release] Merge script should prompt for next version when maintenance branch is created
Posted by GitBox <gi...@apache.org>.
raulcd commented on PR #13708:
URL: https://github.com/apache/arrow/pull/13708#issuecomment-1195231764
> (We need to fix test failures before we merge this.)
Thanks @kou! I just pushed the minor test fix + I've added a test for the filtering on the maintenance branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #13708: ARROW-17025: [Dev][Release] Merge script should prompt for next version when maintenance branch is created
Posted by GitBox <gi...@apache.org>.
raulcd commented on PR #13708:
URL: https://github.com/apache/arrow/pull/13708#issuecomment-1195185165
@kszucs @kou what do you think about this change on the merge script?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #13708: ARROW-17205: [Dev][Release] Merge script should prompt for next version when maintenance branch is created
Posted by GitBox <gi...@apache.org>.
kou commented on code in PR #13708:
URL: https://github.com/apache/arrow/pull/13708#discussion_r929715699
##########
dev/merge_arrow_pr.py:
##########
@@ -350,6 +362,11 @@ def is_merged(self):
def is_mergeable(self):
return bool(self._pr_data["mergeable"])
+ @property
+ def maintenance_branches(self):
+ return [x["name"] for x in self._github_api.get_branches()
+ if "maint-" in x["name"]]
Review Comment:
```suggestion
if x["name"].startswith("maint-")]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13708: ARROW-17205: [Dev][Release] Merge script should prompt for next version when maintenance branch is created
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13708:
URL: https://github.com/apache/arrow/pull/13708#issuecomment-1196202305
Benchmark runs are scheduled for baseline = a5a28377e43b6435eefa5cc684d80d5fb26f387a and contender = 83495257c0881d6f08c38f077e53921ef286fe8a. 83495257c0881d6f08c38f077e53921ef286fe8a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6934a8e8476d4f21baf2a11696de6aff...d4ad6b3021244beaa5ffe5fb7dbb5c63/)
[Failed :arrow_down:0.24% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/86da1a0e3d854659a4cfa7c85dc614eb...5d317dca55d5427a824cb486369ae8ac/)
[Failed :arrow_down:0.27% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4c55abca6fcf4c338d79a7f30f92d277...feff394df2dd4189b6a208dc4c75d0a2/)
[Finished :arrow_down:0.57% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d5e8d5bd3ce643b8853e48523ad09c8c...6b34d5e276594721976897eb8dc000f9/)
Buildkite builds:
[Failed] [`83495257` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1201)
[Failed] [`83495257` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1213)
[Failed] [`83495257` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1195)
[Finished] [`83495257` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1215)
[Failed] [`a5a28377` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1200)
[Failed] [`a5a28377` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1212)
[Finished] [`a5a28377` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1194)
[Finished] [`a5a28377` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1214)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #13708: ARROW-17205: [Dev][Release] Merge script should prompt for next version when maintenance branch is created
Posted by GitBox <gi...@apache.org>.
kou merged PR #13708:
URL: https://github.com/apache/arrow/pull/13708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13708: ARROW-17205: [Dev][Release] Merge script should prompt for next version when maintenance branch is created
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13708:
URL: https://github.com/apache/arrow/pull/13708#issuecomment-1196202399
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4c55abca6fcf4c338d79a7f30f92d277...feff394df2dd4189b6a208dc4c75d0a2/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org