You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 03:48:38 UTC
[PR] test(model): deepen LiteTopicSession state logic coverage [rocketmq-dashboard]
yyqdbngt opened a new pull request, #3278:
URL: https://github.com/apache/rocketmq-dashboard/pull/3278
## Summary
Extends the existing `LiteTopicSessionTest` (2 to 5 tests) to pin down the session state logic used by the Lite Topic pages.
Added cases:
- `hasActiveConsumption` requires the `ACTIVE` status together with a positive consumption rate (zero, null rate, and non-ACTIVE status all disqualify);
- `isExpired` reflects either the `EXPIRED` status or a non-positive `ttlRemaining`, and stays false when both are absent;
- consumption progress returns 0.0 for null/zero totals and for a null consumed count, in addition to the existing percentage case.
## Why
These computed states drive the Lite Topic session list status, expiry handling, and progress bars; only the percentage math was covered before.
## Testing
`mvn -B test -Dtest=LiteTopicSessionTest` — 5/5 pass; checkstyle (validate) clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(model): deepen LiteTopicSession state logic coverage [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3278: test(model): deepen LiteTopicSession state logic coverage
URL: https://github.com/apache/rocketmq-dashboard/pull/3278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org