You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2022/12/14 01:30:25 UTC

[GitHub] [gobblin] ZihanLi58 commented on a diff in pull request #3615: [GOBBLIN-1754] Fixes for mysql store change monitors

ZihanLi58 commented on code in PR #3615:
URL: https://github.com/apache/gobblin/pull/3615#discussion_r1047913439


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/restli/GobblinServiceFlowExecutionResourceHandlerWithWarmStandby.java:
##########
@@ -53,8 +53,15 @@ public void resume(ComplexResourceKey<org.apache.gobblin.service.FlowStatusId, E
     String flowName = key.getKey().getFlowName();
     Long flowExecutionId = key.getKey().getFlowExecutionId();
     try {
+      // If an existing resume or kill request is still pending then do not accept this request
+      if (this.dagActionStore.exists(flowGroup, flowName, flowExecutionId.toString())) {
+        this.handleException(flowGroup, flowName, flowExecutionId.toString(),

Review Comment:
   Should we print out the existing action?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org