You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2023/03/24 19:26:55 UTC

[GitHub] [accumulo] keith-turner commented on a diff in pull request #3255: Convert Bulk Import metadata actions to use Ample

keith-turner commented on code in PR #3255:
URL: https://github.com/apache/accumulo/pull/3255#discussion_r1147979198


##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/CleanUpBulkImport.java:
##########
@@ -53,15 +52,15 @@ public CleanUpBulkImport(BulkInfo info) {
   public Repo<Manager> call(long tid, Manager manager) throws Exception {
     manager.updateBulkImportStatus(info.sourceDir, BulkImportState.CLEANUP);
     log.debug("removing the bulkDir processing flag file in " + info.bulkDir);
+    Ample metadataActions = manager.getContext().getAmple();

Review Comment:
   could name the var `ample`, its shorter but I think its still readable.  This is a stylistic comment, please feel free to ignore it.
   
   ```suggestion
       Ample ample = manager.getContext().getAmple();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org