You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zookeeper.apache.org by ar...@apache.org on 2022/04/08 16:51:12 UTC

[zookeeper] branch branch-3.6 updated: ZOOKEEPER-4516: checkstyle:check is failing

This is an automated email from the ASF dual-hosted git repository.

arshad pushed a commit to branch branch-3.6
in repository https://gitbox.apache.org/repos/asf/zookeeper.git


The following commit(s) were added to refs/heads/branch-3.6 by this push:
     new d6a39920d ZOOKEEPER-4516: checkstyle:check is failing
d6a39920d is described below

commit d6a39920d81abb05cadba4540d6dcb28a5317815
Author: Mohammad Arshad <ar...@apache.org>
AuthorDate: Fri Apr 8 22:21:01 2022 +0530

    ZOOKEEPER-4516: checkstyle:check is failing
    
    Corrected imports and done simple formatting
    
    Author: Mohammad Arshad <ar...@apache.org>
    
    Reviewers: Mate Szalay-Beko <sy...@apache.org>
    
    Closes #1858 from arshadmohammad/ZOOKEEPER-4516-branch-3.6
---
 .../test/java/org/apache/zookeeper/KerberosTicketRenewalTest.java   | 6 ++----
 .../java/org/apache/zookeeper/server/quorum/auth/MiniKdcTest.java   | 4 ----
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/zookeeper-server/src/test/java/org/apache/zookeeper/KerberosTicketRenewalTest.java b/zookeeper-server/src/test/java/org/apache/zookeeper/KerberosTicketRenewalTest.java
index 235a10775..6d35c02f8 100644
--- a/zookeeper-server/src/test/java/org/apache/zookeeper/KerberosTicketRenewalTest.java
+++ b/zookeeper-server/src/test/java/org/apache/zookeeper/KerberosTicketRenewalTest.java
@@ -25,7 +25,6 @@ import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
-
 import java.io.File;
 import java.io.FileWriter;
 import java.io.IOException;
@@ -46,7 +45,6 @@ import org.apache.zookeeper.server.quorum.auth.MiniKdc;
 import org.apache.zookeeper.test.ClientBase;
 import org.junit.After;
 import org.junit.AfterClass;
-import org.junit.Before;
 import org.junit.BeforeClass;
 import org.junit.Test;
 import org.slf4j.Logger;
@@ -216,8 +214,8 @@ public class KerberosTicketRenewalTest {
 
   private static void assertEventually(Duration timeout, Supplier<Boolean> test) {
     long until = System.currentTimeMillis() + timeout.toMillis();
-    while(System.currentTimeMillis() < until) {
-      if(test.get()) {
+    while (System.currentTimeMillis() < until) {
+      if (test.get()) {
         return;
       }
       try {
diff --git a/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/auth/MiniKdcTest.java b/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/auth/MiniKdcTest.java
index 4fac57467..8a4bee53a 100644
--- a/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/auth/MiniKdcTest.java
+++ b/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/auth/MiniKdcTest.java
@@ -23,15 +23,11 @@ import static org.junit.Assert.assertNotSame;
 import java.io.File;
 import java.security.Principal;
 import java.util.Arrays;
-import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
-import java.util.Map;
 import java.util.Set;
 import javax.security.auth.Subject;
 import javax.security.auth.kerberos.KerberosPrincipal;
-import javax.security.auth.login.AppConfigurationEntry;
-import javax.security.auth.login.Configuration;
 import javax.security.auth.login.LoginContext;
 import org.apache.kerby.kerberos.kerb.keytab.Keytab;
 import org.apache.kerby.kerberos.kerb.type.base.PrincipalName;