[GitHub] [superset] etr2460 commented on a change in pull request #13051: fix: add config to disable dataset ownership on the old api

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #13051:
URL: https://github.com/apache/superset/pull/13051#discussion_r573959851



##########
File path: superset/config.py
##########
@@ -1057,6 +1057,10 @@ class CeleryConfig:  # pylint: disable=too-few-public-methods
     'class="alert-link">here</a>.'
 )
 
+# Turn this key to False to disable ownership check on the old dataset MVC and
+# datasource API /datasource/save.
+OLD_API_CHECK_DATASET_OWNERSHIP = True

Review comment:
       If this is deprecated in 2.0, do we think we'll have another way to allow non-owners to edit datasets (perhaps only allowing non-destructive changes)? The concept of shared physical datasets is something that's pretty relied on at Airbnb, and I think is a "good product feature" since it prevents duplication of datasets and ensures everyone is using the same source of truth 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org