You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "sschuberth (via GitHub)" <gi...@apache.org> on 2024/01/11 14:06:47 UTC
[PR] Add a failing test for COMPRESS-657 [commons-compress]
sschuberth opened a new pull request, #460:
URL: https://github.com/apache/commons-compress/pull/460
As requested by @garydgregory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a failing test for COMPRESS-657 [commons-compress]
Posted by "sschuberth (via GitHub)" <gi...@apache.org>.
sschuberth commented on PR #460:
URL: https://github.com/apache/commons-compress/pull/460#issuecomment-1887350112
> I have a fix as well ;-)
Is it different from mine?
> Ah! You'll want to run `mvn` (by itself) before pushing to catch all build errors.
Should be all good now.
PS: I hope the test resource I've added is not too large... the uncompressed TAR is 1.9M 🙄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a failing test for COMPRESS-657 [commons-compress]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #460:
URL: https://github.com/apache/commons-compress/pull/460#issuecomment-1887322428
## [Codecov](https://app.codecov.io/gh/apache/commons-compress/pull/460?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `1 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`363d255`)](https://app.codecov.io/gh/apache/commons-compress/commit/363d2553c34624f8078da7d04220a505b4af9c40?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 80.39% compared to head [(`53d3826`)](https://app.codecov.io/gh/apache/commons-compress/pull/460?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 80.39%.
> Report is 1 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/commons-compress/pull/460?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ommons/compress/archivers/tar/TarArchiveEntry.java](https://app.codecov.io/gh/apache/commons-compress/pull/460?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29tcHJlc3MvYXJjaGl2ZXJzL3Rhci9UYXJBcmNoaXZlRW50cnkuamF2YQ==) | 0.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/commons-compress/pull/460?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #460 +/- ##
=========================================
Coverage 80.39% 80.39%
- Complexity 6717 6718 +1
=========================================
Files 343 343
Lines 24714 24714
Branches 3999 3999
=========================================
Hits 19868 19868
+ Misses 3322 3319 -3
- Partials 1524 1527 +3
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/commons-compress/pull/460?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [COMPRESS-655] Fix TAR directory entries being misinterpreted as files [commons-compress]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #460:
URL: https://github.com/apache/commons-compress/pull/460#issuecomment-1887414414
TY @sschuberth ! Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a failing test for COMPRESS-657 [commons-compress]
Posted by "sschuberth (via GitHub)" <gi...@apache.org>.
sschuberth commented on PR #460:
URL: https://github.com/apache/commons-compress/pull/460#issuecomment-1887283286
Looks like in
public boolean isFile() {
if (file != null) {
return Files.isRegularFile(file, linkOptions);
}
if (linkFlag == LF_OLDNORM || linkFlag == LF_NORMAL) {
return true;
}
return !getName().endsWith("/");
}
`file` is `null`, but `!getName().endsWith("/")` returns `true`. I'll investigate a bit further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [COMPRESS-657] Fix TAR directory entries being misinterpreted as files [commons-compress]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #460:
URL: https://github.com/apache/commons-compress/pull/460#issuecomment-1887426332
https://issues.apache.org/jira/browse/COMPRESS-657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [COMPRESS-655] Fix TAR directory entries being misinterpreted as files [commons-compress]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #460:
URL: https://github.com/apache/commons-compress/pull/460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a failing test for COMPRESS-657 [commons-compress]
Posted by "sschuberth (via GitHub)" <gi...@apache.org>.
sschuberth commented on PR #460:
URL: https://github.com/apache/commons-compress/pull/460#issuecomment-1887300808
Ok, I believe to have a fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a failing test for COMPRESS-657 [commons-compress]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #460:
URL: https://github.com/apache/commons-compress/pull/460#issuecomment-1887319032
I have a fix as well ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org