You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Jochen Wiedmann (Jira)" <ji...@apache.org> on 2021/08/20 08:45:00 UTC
[jira] [Commented] (FILEUPLOAD-341) Move exceptions out of .impl
package
[ https://issues.apache.org/jira/browse/FILEUPLOAD-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402103#comment-17402103 ]
Jochen Wiedmann commented on FILEUPLOAD-341:
--------------------------------------------
[~mgrigorov]: Please verify, whether 8fa525dd420dcfcec0341a445b0d06c811731d99 works for you.
> Move exceptions out of .impl package
> ------------------------------------
>
> Key: FILEUPLOAD-341
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-341
> Project: Commons FileUpload
> Issue Type: Wish
> Affects Versions: 2.0
> Reporter: Martin Tzvetanov Grigorov
> Assignee: Jochen Wiedmann
> Priority: Minor
>
> With FILEUPLOAD-340 commons-fileupload2 now provides a module-info.class that exports all packages but org.apache.commons.fileupload2.impl.
>
> Would it be OK to move all **Exception classes to the parent package so that they are visible by users ?
> **Impl classes should stay in org.apache.commons.fileupload2.impl!
>
> In Apache Wicket we use few of the exception classes to report specific errors:
> * [https://github.com/apache/wicket/blob/43bc9b112ee43fac80f830632415cd8060b3d1a2/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/MultipartServletWebRequestImpl.java#L505]
> * [https://github.com/apache/wicket/blob/270a5a43970cd975539331b21a34bd83a59c9c39/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java#L1504]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)