You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/01/08 05:05:52 UTC
[GitHub] [incubator-echarts] ppbl opened a new issue #13983: data/Source.ts normalizeDimensionsOption 方法直接使用全局 name, 在微信小程序中报错
ppbl opened a new issue #13983:
URL: https://github.com/apache/incubator-echarts/issues/13983
### Version
5.0.0
### Reproduction link
[https://github.com/apache/incubator-echarts/blob/master/src/data/Source.ts#L474](https://github.com/apache/incubator-echarts/blob/master/src/data/Source.ts#L474)
### Steps to reproduce
查看 data/source.ts 第474 行的代码，使用了全局的name（函数内部没有声明 name 变量）
### What is expected?
在微信小程序中使用不报错
### What is actually happening?
报错，name is not defined
---
这个 name 是不是不小心写错了？😂看起来也不像是要故意用全局的 name
<!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
<!-- This issue is in English. DO NOT REMOVE -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] plainheart commented on issue #13983: data/Source.ts normalizeDimensionsOption 方法直接使用全局 name, 在微信小程序中报错
Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #13983:
URL: https://github.com/apache/incubator-echarts/issues/13983#issuecomment-756552597
对比先前代码，感觉应该是 `item.name`。请 @100pah 帮助确认并修复一下。相关的 commit 是 https://github.com/apache/incubator-echarts/commit/bc1f8a0133b9b49ae24fab713c29350a271ad44f
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang closed issue #13983: data/Source.ts normalizeDimensionsOption 方法直接使用全局 name, 在微信小程序中报错
Posted by GitBox <gi...@apache.org>.
pissang closed issue #13983:
URL: https://github.com/apache/incubator-echarts/issues/13983
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on issue #13983: data/Source.ts normalizeDimensionsOption 方法直接使用全局 name, 在微信小程序中报错
Posted by GitBox <gi...@apache.org>.
pissang commented on issue #13983:
URL: https://github.com/apache/incubator-echarts/issues/13983#issuecomment-756567440
@plainheart 我刚提交了修复，可以帮忙 review 一下
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13983: data/Source.ts normalizeDimensionsOption 方法直接使用全局 name, 在微信小程序中报错
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #13983:
URL: https://github.com/apache/incubator-echarts/issues/13983#issuecomment-756548529
Hi! We've received your issue and please be patient to get responded. 🎉
The average response time is expected to be within one day for weekdays.
In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer.
If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical question.
If you are interested in the project, you may also subscribe our [mailing list](https://echarts.apache.org/en/maillist.html).
Have a nice day! 🍵
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org