You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/04/08 15:59:04 UTC
[GitHub] [trafficcontrol] rawlinp opened a new pull request, #6730: t3c race condition timestamp updates
rawlinp opened a new pull request, #6730:
URL: https://github.com/apache/trafficcontrol/pull/6730
Remove the ability to set "update" times via the
/servers/:hostname/update endpoint (only "apply" times are writable via
this endpoint).
Fix docs to reflect the existence of the "updated" and "reval_updated"
query paramters in the /servers/:hostname/update endpoint (kept for
backwards-compatibility).
Correct the date on the DB migration so that it applies after migrations
that were merged earlier.
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Documentation
- Traffic Ops
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
Verify that you cannot update the `config_update_time` or `revalidate_update_time` server fields via the `/servers/:hostname/update` endpoint.
## PR submission checklist
- [ ] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [x] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [x] Feature already contains a changelog entry
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on a diff in pull request #6730: t3c race condition timestamp updates
Posted by GitBox <gi...@apache.org>.
rawlinp commented on code in PR #6730:
URL: https://github.com/apache/trafficcontrol/pull/6730#discussion_r846426151
##########
traffic_ops/traffic_ops_golang/server/update.go:
##########
@@ -155,83 +153,55 @@ func parseQueryParams(params map[string]string) (*updateValues, error) {
// Verify query string parameters
configUpdatedBoolParam, hasConfigUpdatedBoolParam := params["updated"] // Deprecated, but still required for backwards compatibility
revalUpdatedBoolParam, hasRevalUpdatedBoolParam := params["reval_updated"] // Deprecated, but still required for backwards compatibility
- configUpdateTimeParam, hasConfigUpdateTimeParam := params["config_update_time"]
- revalidateUpdateTimeParam, hasRevalidateUpdateTimeParam := params["revalidate_update_time"]
configApplyTimeParam, hasConfigApplyTimeParam := params["config_apply_time"]
revalidateApplyTimeParam, hasRevalidateApplyTimeParam := params["revalidate_apply_time"]
if !hasConfigApplyTimeParam && !hasRevalidateApplyTimeParam &&
- !hasConfigUpdateTimeParam && !hasRevalidateUpdateTimeParam &&
!hasConfigUpdatedBoolParam && !hasRevalUpdatedBoolParam {
- return nil, errors.New("must pass at least one query parameter: 'config_apply_time', 'revalidate_apply_time', 'config_update_time', 'revalidate_update_time' (may also pass bool `update` `reval_updated`)")
+ return nil, errors.New("must pass at least one of the following query parameters: 'config_apply_time', 'revalidate_apply_time' ,'update', 'reval_updated'")
Review Comment:
DOH. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mattjackson220 commented on a diff in pull request #6730: t3c race condition timestamp updates
Posted by GitBox <gi...@apache.org>.
mattjackson220 commented on code in PR #6730:
URL: https://github.com/apache/trafficcontrol/pull/6730#discussion_r846419317
##########
traffic_ops/traffic_ops_golang/server/update.go:
##########
@@ -155,83 +153,55 @@ func parseQueryParams(params map[string]string) (*updateValues, error) {
// Verify query string parameters
configUpdatedBoolParam, hasConfigUpdatedBoolParam := params["updated"] // Deprecated, but still required for backwards compatibility
revalUpdatedBoolParam, hasRevalUpdatedBoolParam := params["reval_updated"] // Deprecated, but still required for backwards compatibility
- configUpdateTimeParam, hasConfigUpdateTimeParam := params["config_update_time"]
- revalidateUpdateTimeParam, hasRevalidateUpdateTimeParam := params["revalidate_update_time"]
configApplyTimeParam, hasConfigApplyTimeParam := params["config_apply_time"]
revalidateApplyTimeParam, hasRevalidateApplyTimeParam := params["revalidate_apply_time"]
if !hasConfigApplyTimeParam && !hasRevalidateApplyTimeParam &&
- !hasConfigUpdateTimeParam && !hasRevalidateUpdateTimeParam &&
!hasConfigUpdatedBoolParam && !hasRevalUpdatedBoolParam {
- return nil, errors.New("must pass at least one query parameter: 'config_apply_time', 'revalidate_apply_time', 'config_update_time', 'revalidate_update_time' (may also pass bool `update` `reval_updated`)")
+ return nil, errors.New("must pass at least one of the following query parameters: 'config_apply_time', 'revalidate_apply_time' ,'update', 'reval_updated'")
Review Comment:
only the smallest comment. this should have `updated` instead of `update`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mattjackson220 merged pull request #6730: t3c race condition timestamp updates
Posted by GitBox <gi...@apache.org>.
mattjackson220 merged PR #6730:
URL: https://github.com/apache/trafficcontrol/pull/6730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org