[GitHub] [hudi] danny0405 commented on a diff in pull request #5830: [HUDI-3981][RFC-33] Flink engine support for comprehensive schema evolution

[GitBox <gi...@apache.org>]

danny0405 commented on code in PR #5830:
URL: https://github.com/apache/hudi/pull/5830#discussion_r1018635942


##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatReader.java:
##########
@@ -141,4 +139,8 @@ public HoodieLogBlock prev() throws IOException {
     return this.currentReader.prev();
   }
 
+  private Schema getReaderSchema() {
+    boolean useWriterSchema = !readerSchema.isEmptySchema();
+    return useWriterSchema ? null : readerSchema.getAvroSchema();

Review Comment:
   This is so confusing, why we use writer schema if the reader schema is not empty ? And what does it means for an empty internal schema ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org