[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2175: Improve CI with cancel & concurrency & paths filter

[GitBox <gi...@apache.org>]

pan3793 commented on a change in pull request #2175:
URL: https://github.com/apache/incubator-kyuubi/pull/2175#discussion_r830470696



##########
File path: .github/workflows/style.yml
##########
@@ -15,19 +15,26 @@
 # limitations under the License.
 #
 
-name: Style check
-
-# This GitHub workflow checks style & dependency issues.
+name: Style
 
 on:
   pull_request:
     branches:
       - master
       - branch-*
 
+concurrency:
+  group: linter-${{ github.ref }}
+  cancel-in-progress: true
+
+# no install runs before style check because it is expensive, we can skip build if style fails
+# Well, sometimes when we introduce a new module, it may 'fail' the style check for missing
+# dependency we just create for other module to inherit.
+# We can ignore this failure and merge the PR, if we see the style check pass on the new module
+  # or via a local quick verification.

Review comment:
       nit: indent




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org