You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by GitBox <gi...@apache.org> on 2022/12/30 21:00:43 UTC
[GitHub] [opennlp] rzo1 opened a new pull request, #476: OPENNLP-1358 - Failing tests on Windows 11 and Java 17
rzo1 opened a new pull request, #476:
URL: https://github.com/apache/opennlp/pull/476
# What does this PR do?
Tests are not failing on Windows anymore. This PR adds build support for Windows (latest = Server 2022) and adjusts test cases (if needed) to be run on GH actions CI.
- Adds CI for Windows (latest = Server 2022, similar to Windows 11) to be able to build / test with Windows
- Unifies how line endings are handled by git via `.gitattributes` as we have a checkstyle rule in place which prohibits the use of CRLF (checkstyle will fail a build on Windows if `git` isn't configured accordingly)
- **Converts** line endings from CRLF to LF (according to supplied `.gitattributes`, see https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings) via `git add --renormalize .`
- Workarounds https://github.com/junit-team/junit5/issues/2811 (`@TempDir` created folders cannot be deleted on Windows Server 2022)
- Removes Coveralls as there is no Jacoco support at the moment (so the step isn't useful anymore): https://github.com/coverallsapp/github-action/issues/22
Matrix build is now happy: https://github.com/rzo1/opennlp/actions/runs/3809019320
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp] rzo1 commented on a diff in pull request #476: OPENNLP-1358 - Failing tests on Windows 11 and Java 17
Posted by GitBox <gi...@apache.org>.
rzo1 commented on code in PR #476:
URL: https://github.com/apache/opennlp/pull/476#discussion_r1059612162
##########
opennlp-tools/src/test/java/opennlp/tools/AbstractTempDirTest.java:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package opennlp.tools;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+
+// Workaround for https://github.com/junit-team/junit5/issues/2811 - we cannot use @TempDir atm.
Review Comment:
Added TODO + reference to OPENNLP-1430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp] kinow commented on a diff in pull request #476: OPENNLP-1358 - Failing tests on Windows 11 and Java 17
Posted by GitBox <gi...@apache.org>.
kinow commented on code in PR #476:
URL: https://github.com/apache/opennlp/pull/476#discussion_r1059526576
##########
.github/workflows/maven.yml:
##########
@@ -23,8 +23,8 @@ jobs:
continue-on-error: ${{ matrix.experimental }}
strategy:
matrix:
- os: [ubuntu-latest]
- java: [ 11 ]
+ os: [ubuntu-latest, windows-latest]
Review Comment:
I read the title of the PR and was going to suggest to enable the GH Actions for Windows, but glad you've already enabled it! Thanks!
##########
opennlp-tools/src/test/java/opennlp/tools/AbstractTempDirTest.java:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package opennlp.tools;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+
+// Workaround for https://github.com/junit-team/junit5/issues/2811 - we cannot use @TempDir atm.
Review Comment:
Add a `TODO`? So we don't forget?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp] mawiesne commented on a diff in pull request #476: OPENNLP-1358 - Failing tests on Windows 11 and Java 17
Posted by GitBox <gi...@apache.org>.
mawiesne commented on code in PR #476:
URL: https://github.com/apache/opennlp/pull/476#discussion_r1059527531
##########
opennlp-tools/src/test/java/opennlp/tools/AbstractTempDirTest.java:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package opennlp.tools;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+
+// Workaround for https://github.com/junit-team/junit5/issues/2811 - we cannot use @TempDir atm.
Review Comment:
Or, leave a Jira issue for cleanup of that workaround?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp] jzonthemtn merged pull request #476: OPENNLP-1358 - Failing tests on Windows 11 and Java 17
Posted by GitBox <gi...@apache.org>.
jzonthemtn merged PR #476:
URL: https://github.com/apache/opennlp/pull/476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org