You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "JeremyXin (via GitHub)" <gi...@apache.org> on 2026/08/19 01:58:52 UTC
[PR] [Fix][Zeta] Align Hazelcast join port try count with port range [seatunnel]
JeremyXin opened a new pull request, #11868:
URL: https://github.com/apache/seatunnel/pull/11868
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
### Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
This PR fixes an inconsistent Hazelcast test configuration in `AbstractSeaTunnelServerTest`.
Previously, `port-count` was set to `100`, but `hazelcast.tcp.join.port.try.count` was only `30`.
When the test node bound to a port outside the first 30 candidates, Hazelcast join could fail to discover the node itself, which could cause UTs such as `CheckpointTimeOutTest` to fail with:
`java.lang.IllegalStateException: Node failed to start!`
### What is changed
- Align `hazelcast.tcp.join.port.try.count` with `port-count`
- Change the value from `30` to `100`
### Result
This reduces CI instability caused by the mismatch between Hazelcast bind port range and join scan range in engine server tests.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released SeaTunnel versions or within the unreleased branches such as dev.
If no, write 'No'.
If you are adding/modifying connector documents, please follow our new specifications: https://github.com/apache/seatunnel/issues/4544.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If you are adding E2E test cases, maybe refer to https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf, here is a good example.
-->
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If necessary, please update `incompatible-changes.md` to describe the incompatibility caused by this PR.
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
2. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in [label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in [seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
5. Update connector [plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Zeta] Align Hazelcast join port try count with port range [seatunnel]
Posted by "nzw921rx (via GitHub)" <gi...@apache.org>.
nzw921rx merged PR #11868:
URL: https://github.com/apache/seatunnel/pull/11868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Zeta] Align Hazelcast join port try count with port range [seatunnel]
Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo commented on PR #11868:
URL: https://github.com/apache/seatunnel/pull/11868#issuecomment-6393823950
Synchronized with current `dev` and resolved both test-fixture conflicts in `4d7cddba7c3a`. The join-port-count invariant and its regression assertions are retained together with the newer IPv4 loopback fix for Windows discovery.
This remains a configuration-and-test change: the embedded Hazelcast discovery probe count is aligned with the configured member port range, including the production configuration already changed by this PR. No test is disabled or weakened. Affected common/core/server formatting and static diff checks passed.
Fresh current-head GitHub CI still needs to complete before this can be considered validated; the old run has already reached attempt 24, so I did not add another speculative retry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Zeta] Align Hazelcast join port try count with port range [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11868:
URL: https://github.com/apache/seatunnel/pull/11868#issuecomment-5473747683
CI record update, @JeremyXin — following up again since the `Build` check has been rerun to attempt 19 since my last note.
That attempt (fork run `32352285042`, attempt 19, started 2026-08-29T14:21:23Z — after my previous comment) also failed, but this time the concerning-looking one is `unit-test (11, windows-latest)`: `CheckpointCoordinatorTest > AbstractSeaTunnelServerTest.before:73 » IllegalState: Node failed to start!`, after a ~311.8s hang, with no bind-exception or other root cause captured in the surefire output.
I want to be precise about why I don't think this is a regression of this PR's own fix, even though it's technically the same exception text and the same base class this PR modifies:
- The failure took ~311s to surface (essentially a full startup-timeout hang), not an immediate bind/joiner failure. A genuine port-try-count-too-small regression would fail fast during joiner discovery, not hang for over five minutes.
- I've now seen this exact signature — `IllegalStateException: Node failed to start!` on `windows-latest`, ~310s elapsed, a different `AbstractSeaTunnelServerTest` subclass each time, no captured cause — on another unrelated PR in this same review batch (PR #11864, `unit-test (11, windows-latest)` / `JobStateCleanupDelayTest`, ~311s). Two independent PRs touching completely different code (Postgres-CDC vs. Hazelcast join config) hitting the identical timing/exception fingerprint on the same OS/runner is strong evidence this is a shared Windows CI infra flake, not something either diff introduced.
- The actual fix this PR ships (`hazelcast.tcp.join.port.try.count` raised to match `port-count: 100`) is still present and correct in the current head, and I re-confirmed the previously-failing `OptionRulesApiTest` Windows job (the concrete regression I originally blocked on) has not recurred in this or the prior attempt.
My "Ready to merge" conclusion from 2026-08-20 stands. At 19 rerun attempts with a different unrelated flaky job/class failing almost every time, I don't think further reruns are a productive way to reach a clean run — I'd recommend a maintainer with write access merge on the strength of the code review rather than continuing to wait for an all-green attempt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Zeta] Align Hazelcast join port try count with port range [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11868:
URL: https://github.com/apache/seatunnel/pull/11868#issuecomment-5379464099
CI record correction on my own approval, @JeremyXin — the fix itself is unaffected, but I want to be precise about what's currently red.
When I approved, I cited a confirmed-green rerun of `Build` run `32352285042` (fork run, head `9b95505c7a71`). That run's overall conclusion has since flipped to failure — but checking the individual jobs, that's because three of its jobs were re-run a day later (2026-08-21) and hit new, unrelated failures, not a regression in anything this PR touched:
- `all-connectors-it-6 (8, ubuntu-latest)` — `Couchbase` container startup failure, matching a known dev-red Couchbase bootstrap-break pattern (~20s `Connection reset` against the Couchbase container) that's been hitting unrelated PRs since mid-August.
- `paimon-connector-it (8, ubuntu-latest)` — `PaimonSinkCDCIT.testSinkWithIncompatibleSchema` failure, a Paimon schema-compatibility assertion with nothing to do with Hazelcast join ports.
- `all-connectors-it-5 (8, ubuntu-latest)` and the `(11, ...)` variants of these three jobs were cancelled as a side effect.
None of these touch `seatunnel-engine-common`, Hazelcast config, or any of the test classes this PR modified (`AbstractSeaTunnelServerTest`, `WorkerTagTest`, `OptionRulesApiTest`, `RestApiSubmitJobStartWithSavePointTest`, `RestApiSubmitJobConfigShadeDecryptTest`). So to be clear: the specific concern I raised and then cleared in my last review (the Windows `OptionRulesApiTest` "Node failed to start!" failure) is still resolved — it hasn't recurred. This is a separate, later, unrelated flake from re-running other jobs in the same workflow run.
My "Ready to merge" conclusion stands. A rerun of the three affected jobs should get this back to green; no action needed on your end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Zeta] Align Hazelcast join port try count with port range [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11868:
URL: https://github.com/apache/seatunnel/pull/11868#issuecomment-5459188917
CI record update, @JeremyXin — following up on my 2026-08-22 note again, since the `Build` check has since been rerun many more times (this fork run is now on attempt 18) without landing on a clean, unrelated-flake-free result yet.
The most recent completed attempt on this exact head (`9b95505c7`) failed on two jobs, both again unrelated to this PR's Hazelcast join-port fix:
- `unit-test (11, ubuntu-latest)`: `SeaTunnelClientTest.testGetMultiTableJobMetrics` — an assertion failure (`expected: <true> but was: <false>`) in an unrelated metrics-reporting test; nothing in this PR touches `seatunnel-engine-client` or job metrics.
- `jdbc-connectors-it-part-6 (8, ubuntu-latest)`: `JdbcHanaIT` — a Testcontainers `ContainerLaunchException` failing to start the `saplabs/hanaexpress` image; a Docker/infra flake, unrelated to Hazelcast config or the test classes this PR modified.
Neither failure touches `AbstractSeaTunnelServerTest`, `WorkerTagTest`, `OptionRulesApiTest`, or any Hazelcast join/port-count code path. My "Ready to merge" conclusion still stands technically — but at this point the pattern across 18 rerun attempts is a different unrelated flaky job failing each time rather than converging to green, which looks like general CI/Docker capacity churn on this run rather than something a rerun reliably fixes. I would not keep force-rerunning; instead, please flag this to a maintainer with write access so they can either merge on the strength of the code review once any one run comes back clean, or advise if there's a known infra issue affecting these jobs right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Zeta] Align Hazelcast join port try count with port range [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11868:
URL: https://github.com/apache/seatunnel/pull/11868#issuecomment-5551396827
Flagging a merge-state fact I haven't called out separately before: GitHub currently reports this branch as `dirty` (`mergeable: false`, not rebaseable) against `dev` — this is on top of, and separate from, the Windows `unit-test` flake I've been tracking here. Given `behind_by=154`, that's not surprising, but it hasn't been mentioned explicitly yet.
@JeremyXin could you sync the latest `dev` and resolve the conflicts? Once that's done and a fresh `Build` run completes, I'm happy to take another look at both the CI signal and the merge state together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org