You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Balázs Bence Sári <bs...@hortonworks.com> on 2017/07/05 20:32:32 UTC
Review Request 60668: Fixed outdated index.html generation in
ambari-server/target/generated-sources/swagger
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60668/
-----------------------------------------------------------
Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, and Sebastian Toader.
Bugs: AMBARI-21410
https://issues.apache.org/jira/browse/AMBARI-21410
Repository: ambari
Description
-------
The input for html generation is taken from the correct source (ambari-server/target/generated-sources/swagger/swagger.json instead of ambari-server/docs/api/generated/swagger.json).
Diffs
-----
ambari-server/pom.xml 878665e
Diff: https://reviews.apache.org/r/60668/diff/1/
Testing
-------
Manually tested docs generation both with and without the -Dgenerate.swagger.resources flag.
Thanks,
Balázs Bence Sári
Re: Review Request 60668: Fixed outdated index.html generation in
ambari-server/target/generated-sources/swagger
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60668/#review182379
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On July 5, 2017, 10:32 p.m., Balázs Bence Sári wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60668/
> -----------------------------------------------------------
>
> (Updated July 5, 2017, 10:32 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, and Sebastian Toader.
>
>
> Bugs: AMBARI-21410
> https://issues.apache.org/jira/browse/AMBARI-21410
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The input for html generation is taken from the correct source (ambari-server/target/generated-sources/swagger/swagger.json instead of ambari-server/docs/api/generated/swagger.json).
>
>
> Diffs
> -----
>
> ambari-server/pom.xml 878665e
>
>
> Diff: https://reviews.apache.org/r/60668/diff/1/
>
>
> Testing
> -------
>
> Manually tested docs generation both with and without the -Dgenerate.swagger.resources flag.
>
>
> Thanks,
>
> Balázs Bence Sári
>
>
Re: Review Request 60668: Fixed outdated index.html generation in
ambari-server/target/generated-sources/swagger
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60668/#review179761
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Doroszlai
On July 5, 2017, 10:32 p.m., Balázs Bence Sári wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60668/
> -----------------------------------------------------------
>
> (Updated July 5, 2017, 10:32 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, and Sebastian Toader.
>
>
> Bugs: AMBARI-21410
> https://issues.apache.org/jira/browse/AMBARI-21410
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The input for html generation is taken from the correct source (ambari-server/target/generated-sources/swagger/swagger.json instead of ambari-server/docs/api/generated/swagger.json).
>
>
> Diffs
> -----
>
> ambari-server/pom.xml 878665e
>
>
> Diff: https://reviews.apache.org/r/60668/diff/1/
>
>
> Testing
> -------
>
> Manually tested docs generation both with and without the -Dgenerate.swagger.resources flag.
>
>
> Thanks,
>
> Balázs Bence Sári
>
>