You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/04 10:35:51 UTC

[GitHub] [pulsar] cbornet commented on pull request #13298: [11646][Pulsar Java client] Fix ConfigurationDataUtils loadConf strategy

cbornet commented on PR #13298:
URL: https://github.com/apache/pulsar/pull/13298#issuecomment-1303237568

   Although I think the DeadLetterPolicy crash is solved by https://github.com/apache/pulsar/issues/16487, we still have the issue that `loadConf` resets non-serializable fields to `null`. This PR prevents that.
   Also it should be documented that `loadConf` only loads fields that are serializable. For instance, `loadConf(Map.of("messageListener", messageListener))` does nothing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org