[jira] [Resolved] (YETUS-1222) smart-apply-patch EXTRA_ARGS should be an array

["Allen Wittenauer (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YETUS-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Allen Wittenauer resolved YETUS-1222.
-------------------------------------
    Fix Version/s: 0.15.0
       Resolution: Fixed

thanks for the review [~ndimiduk]!

Merged.

> smart-apply-patch EXTRA_ARGS should be an array
> -----------------------------------------------
>
>                 Key: YETUS-1222
>                 URL: https://issues.apache.org/jira/browse/YETUS-1222
>             Project: Yetus
>          Issue Type: Bug
>          Components: Precommit
>    Affects Versions: 0.14.1
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Major
>             Fix For: 0.15.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> There is an unprotected EXTRA_ARGS in smart-apply-patch that newer versions of shellcheck (correctly) mark as SC2086.  Given that it appears to be undocumented and  how passing --gpg-sign will break any external input, let's change it to correctly be an array.  It is still not recommended to depend on this variable, however.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)