You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/07 21:01:57 UTC
[GitHub] [superset] jfrag1 opened a new pull request #13998: Fix execution log when no execution id
jfrag1 opened a new pull request #13998:
URL: https://github.com/apache/superset/pull/13998
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
An issue was introduced in #13752 where logs that were created before the `executionId` was created cause the execution log list view to give the following error:
<img width="617" alt="Screen Shot 2021-04-07 at 1 49 37 PM" src="https://user-images.githubusercontent.com/47196419/113933516-8ca7b380-97a9-11eb-8600-f539605fc8e5.png">
This PR fixes this issue, instead displaying "none" for logs without an `executionId`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13998: fix: execution log crashes for logs with no uuid
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13998:
URL: https://github.com/apache/superset/pull/13998#issuecomment-815313410
# [Codecov](https://codecov.io/gh/apache/superset/pull/13998?src=pr&el=h1) Report
> Merging [#13998](https://codecov.io/gh/apache/superset/pull/13998?src=pr&el=desc) (48cb5ed) into [master](https://codecov.io/gh/apache/superset/commit/dcb9f7cff186d03702725da0c0ad090a9a3e3764?el=desc) (dcb9f7c) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 48cb5ed differs from pull request most recent head 7cfb9d8. Consider uploading reports for the commit 7cfb9d8 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13998?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13998 +/- ##
==========================================
+ Coverage 79.02% 79.03% +0.01%
==========================================
Files 936 936
Lines 47408 47408
Branches 5938 5939 +1
==========================================
+ Hits 37465 37471 +6
+ Misses 9817 9811 -6
Partials 126 126
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `68.85% <100.00%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13998?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/components/IndeterminateCheckbox/index.tsx](https://codecov.io/gh/apache/superset/pull/13998/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94L2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ntend/src/dashboard/components/CssEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/13998/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci9pbmRleC5qc3g=) | `95.83% <ø> (ø)` | |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13998/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13998?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13998?src=pr&el=footer). Last update [dcb9f7c...7cfb9d8](https://codecov.io/gh/apache/superset/pull/13998?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on pull request #13998: fix: execution log crashes for logs with no uuid
Posted by GitBox <gi...@apache.org>.
yousoph commented on pull request #13998:
URL: https://github.com/apache/superset/pull/13998#issuecomment-816265150
🏷️ 2021.13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13998: fix: execution log crashes for logs with no uuid
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13998:
URL: https://github.com/apache/superset/pull/13998#issuecomment-815313410
# [Codecov](https://codecov.io/gh/apache/superset/pull/13998?src=pr&el=h1) Report
> Merging [#13998](https://codecov.io/gh/apache/superset/pull/13998?src=pr&el=desc) (48cb5ed) into [master](https://codecov.io/gh/apache/superset/commit/dcb9f7cff186d03702725da0c0ad090a9a3e3764?el=desc) (dcb9f7c) will **decrease** coverage by `0.64%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 48cb5ed differs from pull request most recent head 7cfb9d8. Consider uploading reports for the commit 7cfb9d8 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13998?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13998 +/- ##
==========================================
- Coverage 79.02% 78.38% -0.65%
==========================================
Files 936 936
Lines 47408 47408
Branches 5938 5939 +1
==========================================
- Hits 37465 37160 -305
- Misses 9817 10104 +287
- Partials 126 144 +18
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.13% <ø> (-4.91%)` | :arrow_down: |
| javascript | `68.85% <100.00%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13998?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/components/IndeterminateCheckbox/index.tsx](https://codecov.io/gh/apache/superset/pull/13998/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94L2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ntend/src/dashboard/components/CssEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/13998/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci9pbmRleC5qc3g=) | `95.83% <ø> (ø)` | |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13998/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/13998/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `25.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...erset-frontend/src/common/hooks/useUrlShortener.ts](https://codecov.io/gh/apache/superset/pull/13998/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VVcmxTaG9ydGVuZXIudHM=) | `50.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13998/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...mponents/controls/AnnotationLayerControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13998/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL2luZGV4LmpzeA==) | `42.85% <0.00%> (-40.00%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/13998/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13998/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `72.72% <0.00%> (-27.28%)` | :arrow_down: |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13998/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `71.66% <0.00%> (-23.34%)` | :arrow_down: |
| ... and [42 more](https://codecov.io/gh/apache/superset/pull/13998/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13998?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13998?src=pr&el=footer). Last update [dcb9f7c...7cfb9d8](https://codecov.io/gh/apache/superset/pull/13998?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13998: fix: execution log crashes for logs with no uuid
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13998:
URL: https://github.com/apache/superset/pull/13998#issuecomment-815313410
# [Codecov](https://codecov.io/gh/apache/superset/pull/13998?src=pr&el=h1) Report
> Merging [#13998](https://codecov.io/gh/apache/superset/pull/13998?src=pr&el=desc) (48cb5ed) into [master](https://codecov.io/gh/apache/superset/commit/dcb9f7cff186d03702725da0c0ad090a9a3e3764?el=desc) (dcb9f7c) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 48cb5ed differs from pull request most recent head 7cfb9d8. Consider uploading reports for the commit 7cfb9d8 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13998?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13998 +/- ##
==========================================
+ Coverage 79.02% 79.03% +0.01%
==========================================
Files 936 936
Lines 47408 47408
Branches 5938 5939 +1
==========================================
+ Hits 37465 37471 +6
+ Misses 9817 9811 -6
Partials 126 126
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <ø> (ø)` | |
| javascript | `68.85% <100.00%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13998?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/components/IndeterminateCheckbox/index.tsx](https://codecov.io/gh/apache/superset/pull/13998/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94L2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ntend/src/dashboard/components/CssEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/13998/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci9pbmRleC5qc3g=) | `95.83% <ø> (ø)` | |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13998/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13998?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13998?src=pr&el=footer). Last update [dcb9f7c...7cfb9d8](https://codecov.io/gh/apache/superset/pull/13998?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] willbarrett merged pull request #13998: fix: execution log crashes for logs with no uuid
Posted by GitBox <gi...@apache.org>.
willbarrett merged pull request #13998:
URL: https://github.com/apache/superset/pull/13998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org