You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/20 06:02:20 UTC

[GitHub] [arrow] thisisnic commented on a change in pull request #10751: ARROW-13201: [R] Add binding for coalesce()

thisisnic commented on a change in pull request #10751:
URL: https://github.com/apache/arrow/pull/10751#discussion_r672829190



##########
File path: r/NEWS.md
##########
@@ -26,7 +26,7 @@
   * String operations: `strsplit()` and `str_split()`; `strptime()`; `paste()`, `paste0()`, and `str_c()`; `substr()` and `str_sub()`; `str_like()`; `str_pad()`; `stri_reverse()`
   * Date/time operations: `lubridate` methods such as `year()`, `month()`, `wday()`, and so on
   * Math: logarithms (`log()` et al.); trigonometry (`sin()`, `cos()`, et al.); `abs()`; `sign()`; `pmin()` and `pmax()`; `ceiling()`, `floor()`, and `trunc()`
-  * Conditional: `ifelse()` and `if_else()` (fixed-precision decimal numbers do not yet work and factors/dictionaries are converted to character strings); `case_when()` (currently works with numeric data types but not character strings, factors/dictionaries, or lists/structs)
+  * Conditional: `ifelse()` and `if_else()` (fixed-precision decimal numbers do not yet work and factors/dictionaries are converted to character strings); `case_when()` (currently works with numeric data types but not character strings, factors/dictionaries, or lists/structs); `coalesce()` (lists/structs do not work and factors/dictionaries are converted to character strings)

Review comment:
       Super-pedantic, but when I read "do not work" it makes me wonder whether I can input these types and the results will be wrong, or if they'll return an error.
   
   ```suggestion
     * Conditional: `ifelse()` and `if_else()` (fixed-precision decimal numbers not yet implemented and factors/dictionaries are converted to character strings); `case_when()` (currently works with numeric data types but not character strings, factors/dictionaries, or lists/structs); `coalesce()` (lists/structs not yet implemented and factors/dictionaries are converted to character strings)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org