You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/04/27 22:14:42 UTC
Review Request 58820: Explained how container working directory
differs from its sandbox.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58820/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs
-----
include/mesos/slave/containerizer.proto c30b1fc659ee9b3cd343899638ced6408d8b51a2
src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
Diff: https://reviews.apache.org/r/58820/diff/1/
Testing
-------
None: not a functional change.
Thanks,
Alexander Rukletsov
Re: Review Request 58820: Explained how container working directory
differs from its sandbox.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58820/#review173271
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/slave/containerizer.proto
Lines 187 (patched)
<https://reviews.apache.org/r/58820/#comment246312>
and the container defines an image.
- Jie Yu
On April 27, 2017, 10:14 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58820/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 10:14 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/slave/containerizer.proto c30b1fc659ee9b3cd343899638ced6408d8b51a2
> src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
>
>
> Diff: https://reviews.apache.org/r/58820/diff/1/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58820: Explained how container working directory
differs from its sandbox.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On April 28, 2017, 8:37 p.m., Vinod Kone wrote:
> > include/mesos/slave/containerizer.proto
> > Line 186 (original), 186 (patched)
> > <https://reviews.apache.org/r/58820/diff/2/?file=1703232#file1703232line186>
> >
> > s/sandbox/sandbox in the host (or is it container?) mount namespace/ ?
> >
> > also, not clear what "Mesos sandbox" means? do you mean the value of 'MESOS_SANDBOX' env variable?
Well, the container can always access its sandbox, regardless whether it shares the host filesystem or not. I'm not sure we should refer to the env variable name here, even though we now indeed set both to the same value (modulo the comment). Jie, what do you think?
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58820/#review173378
-----------------------------------------------------------
On May 3, 2017, 4:45 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58820/
> -----------------------------------------------------------
>
> (Updated May 3, 2017, 4:45 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/slave/containerizer.proto c30b1fc659ee9b3cd343899638ced6408d8b51a2
> src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
>
>
> Diff: https://reviews.apache.org/r/58820/diff/3/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58820: Explained how container working directory
differs from its sandbox.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58820/#review173378
-----------------------------------------------------------
include/mesos/slave/containerizer.proto
Line 186 (original), 186 (patched)
<https://reviews.apache.org/r/58820/#comment246384>
s/sandbox/sandbox in the host (or is it container?) mount namespace/ ?
also, not clear what "Mesos sandbox" means? do you mean the value of 'MESOS_SANDBOX' env variable?
include/mesos/slave/containerizer.proto
Lines 187 (patched)
<https://reviews.apache.org/r/58820/#comment246383>
s/the image/an image/
- Vinod Kone
On April 28, 2017, 4:14 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58820/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 4:14 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/slave/containerizer.proto c30b1fc659ee9b3cd343899638ced6408d8b51a2
> src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
>
>
> Diff: https://reviews.apache.org/r/58820/diff/2/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58820: Explained how container working directory
differs from its sandbox.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58820/
-----------------------------------------------------------
(Updated May 9, 2017, 2:31 p.m.)
Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
Changes
-------
Rebased. NNTR.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/slave/containerizer.proto 41f2905df690bfe88ed762f1cd1246689fa4d3ea
src/slave/containerizer/mesos/containerizer.cpp 3d724945812c0359ed175ce232f70886dc4401c8
Diff: https://reviews.apache.org/r/58820/diff/4/
Changes: https://reviews.apache.org/r/58820/diff/3-4/
Testing
-------
None: not a functional change.
Thanks,
Alexander Rukletsov
Re: Review Request 58820: Explained how container working directory
differs from its sandbox.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58820/
-----------------------------------------------------------
(Updated May 3, 2017, 4:45 p.m.)
Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
Changes
-------
Addressed comments.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/slave/containerizer.proto c30b1fc659ee9b3cd343899638ced6408d8b51a2
src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
Diff: https://reviews.apache.org/r/58820/diff/3/
Changes: https://reviews.apache.org/r/58820/diff/2-3/
Testing
-------
None: not a functional change.
Thanks,
Alexander Rukletsov
Re: Review Request 58820: Explained how container working directory
differs from its sandbox.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58820/
-----------------------------------------------------------
(Updated April 28, 2017, 4:14 p.m.)
Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
Changes
-------
Addressed comments.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/slave/containerizer.proto c30b1fc659ee9b3cd343899638ced6408d8b51a2
src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
Diff: https://reviews.apache.org/r/58820/diff/2/
Changes: https://reviews.apache.org/r/58820/diff/1-2/
Testing
-------
None: not a functional change.
Thanks,
Alexander Rukletsov