You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by br...@apache.org on 2009/02/23 18:49:25 UTC
svn commit: r747090 -
/incubator/thrift/trunk/compiler/cpp/src/generate/t_java_generator.cc
Author: bryanduxbury
Date: Mon Feb 23 17:49:24 2009
New Revision: 747090
URL: http://svn.apache.org/viewvc?rev=747090&view=rev
Log:
THRIFT-116. java: Isset fields for non-primitive types unnecessary
Prior commit on this issue was missing a !.
Modified:
incubator/thrift/trunk/compiler/cpp/src/generate/t_java_generator.cc
Modified: incubator/thrift/trunk/compiler/cpp/src/generate/t_java_generator.cc
URL: http://svn.apache.org/viewvc/incubator/thrift/trunk/compiler/cpp/src/generate/t_java_generator.cc?rev=747090&r1=747089&r2=747090&view=diff
==============================================================================
--- incubator/thrift/trunk/compiler/cpp/src/generate/t_java_generator.cc (original)
+++ incubator/thrift/trunk/compiler/cpp/src/generate/t_java_generator.cc Mon Feb 23 17:49:24 2009
@@ -1014,7 +1014,7 @@
if ((*f_iter)->get_req() == t_field::T_REQUIRED) {
if (bean_style_) {
out <<
- indent() << "if (" << generate_isset_check(*f_iter) << ") {" << endl <<
+ indent() << "if (!" << generate_isset_check(*f_iter) << ") {" << endl <<
indent() << " throw new TProtocolException(\"Required field '" << (*f_iter)->get_name() << "' is unset! Struct:\" + toString());" << endl <<
indent() << "}" << endl << endl;
} else{