You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/08/27 16:44:54 UTC
[GitHub] [incubator-nuttx] gustavonihei opened a new pull request #4424: drivers/mtd: Fix /proc/partitions column alignment on NSH
gustavonihei opened a new pull request #4424:
URL: https://github.com/apache/incubator-nuttx/pull/4424
## Summary
This PR intends to bring one cosmetic fix to the output of `cat /proc/partitions` command when `CONFIG_MTD_PARTITION_NAMES` is selected.
## Impact
Previously:
```
nsh> cat /proc/partitions
Name Start Size MTD
(noname) 16 256 esp32_mainflash
(noname) 272 256 esp32_mainflash
(noname) 528 64 esp32_mainflash
(noname) 592 256 esp32_mainflash
```
Fixed:
```
nsh> cat /proc/partitions
Name Start Size MTD
(noname) 16 256 esp32_mainflash
(noname) 272 256 esp32_mainflash
(noname) 528 64 esp32_mainflash
(noname) 592 256 esp32_mainflash
```
## Testing
Tested on `esp32-wrover-kit`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4424: drivers/mtd: Fix /proc/partitions column alignment on NSH
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4424:
URL: https://github.com/apache/incubator-nuttx/pull/4424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4424: drivers/mtd: Fix /proc/partitions column alignment on NSH
Posted by GitBox <gi...@apache.org>.
saramonteiro commented on a change in pull request #4424:
URL: https://github.com/apache/incubator-nuttx/pull/4424#discussion_r697598940
##########
File path: drivers/mtd/mtd_partition.c
##########
@@ -632,7 +632,8 @@ static ssize_t part_procfs_read(FAR struct file *filep, FAR char *buffer,
/* Terminate the partition name and add to output buffer */
- ret = snprintf(&buffer[total], buflen - total, "%s%7ju %ju %s\n",
+ ret = snprintf(&buffer[total], buflen - total,
+ "%s%7ju %7ju %s\n",
Review comment:
just a nit: enjoy to align the parameters below to `&buffer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4424: drivers/mtd: Fix /proc/partitions column alignment on NSH
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4424:
URL: https://github.com/apache/incubator-nuttx/pull/4424#discussion_r697608735
##########
File path: drivers/mtd/mtd_partition.c
##########
@@ -632,7 +632,8 @@ static ssize_t part_procfs_read(FAR struct file *filep, FAR char *buffer,
/* Terminate the partition name and add to output buffer */
- ret = snprintf(&buffer[total], buflen - total, "%s%7ju %ju %s\n",
+ ret = snprintf(&buffer[total], buflen - total,
+ "%s%7ju %7ju %s\n",
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org