You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/14 21:29:53 UTC
[GitHub] [arrow] westonpace opened a new pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
westonpace opened a new pull request #12425:
URL: https://github.com/apache/arrow/pull/12425
Announcement: https://github.blog/changelog/2022-01-11-github-actions-jobs-running-on-windows-latest-are-now-running-on-windows-server-2022/
It will be rolling out over the next 8 weeks. I noticed because they changed one of the runners for my local fork.
Some of our builds assume windows-latest means 2019.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12425:
URL: https://github.com/apache/arrow/pull/12425#issuecomment-1043063415
Benchmark runs are scheduled for baseline = 74f512260fa69903feac61e1287f6954a3d98204 and contender = d33b6a50d5a49c7cd8918644e5ea8fd50a35c052. d33b6a50d5a49c7cd8918644e5ea8fd50a35c052 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7b33e4d8929944749d78fd64bf5054fa...92e12133ca974b67a6eb871371faabdc/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/34fcb6b914b4436fae5816b099686be4...e54e5bc2c287422e9d0198f1a67a2ffb/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2f00fea949d543acae398e06ffb8787f...7bb20e92eb9a46b2ad73e6fd1ab2dde6/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ce98c7d67ad84386b4028c02679b0d02...95de78810d2d4238b8b1ac15a5ea6129/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12425:
URL: https://github.com/apache/arrow/pull/12425#issuecomment-1043063415
Benchmark runs are scheduled for baseline = 74f512260fa69903feac61e1287f6954a3d98204 and contender = d33b6a50d5a49c7cd8918644e5ea8fd50a35c052. d33b6a50d5a49c7cd8918644e5ea8fd50a35c052 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7b33e4d8929944749d78fd64bf5054fa...92e12133ca974b67a6eb871371faabdc/)
[Failed :arrow_down:1.44% :arrow_up:0.08%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/34fcb6b914b4436fae5816b099686be4...e54e5bc2c287422e9d0198f1a67a2ffb/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2f00fea949d543acae398e06ffb8787f...7bb20e92eb9a46b2ad73e6fd1ab2dde6/)
[Finished :arrow_down:0.13% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ce98c7d67ad84386b4028c02679b0d02...95de78810d2d4238b8b1ac15a5ea6129/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a change in pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #12425:
URL: https://github.com/apache/arrow/pull/12425#discussion_r806280641
##########
File path: .github/workflows/js.yml
##########
@@ -94,7 +94,7 @@ jobs:
windows:
name: AMD64 Windows 2019 NodeJS ${{ matrix.node }}
- runs-on: windows-latest
+ runs-on: windows-2019
Review comment:
Thanks, I'll leave it at `windows-latest` then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12425:
URL: https://github.com/apache/arrow/pull/12425#issuecomment-1043063415
Benchmark runs are scheduled for baseline = 74f512260fa69903feac61e1287f6954a3d98204 and contender = d33b6a50d5a49c7cd8918644e5ea8fd50a35c052. d33b6a50d5a49c7cd8918644e5ea8fd50a35c052 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7b33e4d8929944749d78fd64bf5054fa...92e12133ca974b67a6eb871371faabdc/)
[Failed :arrow_down:1.44% :arrow_up:0.08%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/34fcb6b914b4436fae5816b099686be4...e54e5bc2c287422e9d0198f1a67a2ffb/)
[Failed :arrow_down:9.39% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2f00fea949d543acae398e06ffb8787f...7bb20e92eb9a46b2ad73e6fd1ab2dde6/)
[Finished :arrow_down:0.13% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ce98c7d67ad84386b4028c02679b0d02...95de78810d2d4238b8b1ac15a5ea6129/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #12425:
URL: https://github.com/apache/arrow/pull/12425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on a change in pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
Posted by GitBox <gi...@apache.org>.
domoritz commented on a change in pull request #12425:
URL: https://github.com/apache/arrow/pull/12425#discussion_r806279225
##########
File path: .github/workflows/js.yml
##########
@@ -94,7 +94,7 @@ jobs:
windows:
name: AMD64 Windows 2019 NodeJS ${{ matrix.node }}
- runs-on: windows-latest
+ runs-on: windows-2019
Review comment:
I don't think it should matter at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on a change in pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
Posted by GitBox <gi...@apache.org>.
domoritz commented on a change in pull request #12425:
URL: https://github.com/apache/arrow/pull/12425#discussion_r806279225
##########
File path: .github/workflows/js.yml
##########
@@ -94,7 +94,7 @@ jobs:
windows:
name: AMD64 Windows 2019 NodeJS ${{ matrix.node }}
- runs-on: windows-latest
+ runs-on: windows-2019
Review comment:
I don't think it should matter at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12425:
URL: https://github.com/apache/arrow/pull/12425#issuecomment-1039583034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12425:
URL: https://github.com/apache/arrow/pull/12425#discussion_r807100471
##########
File path: .github/workflows/cpp.yml
##########
@@ -186,9 +186,9 @@ jobs:
fail-fast: false
matrix:
os:
- - windows-latest
+ - windows-2019
include:
- - os: windows-latest
+ - os: windows-2019
Review comment:
I'd rather downgrade the GHA runner for now as an older generator is more likely to hit limitations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on a change in pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
Posted by GitBox <gi...@apache.org>.
emkornfield commented on a change in pull request #12425:
URL: https://github.com/apache/arrow/pull/12425#discussion_r806280633
##########
File path: .github/workflows/go.yml
##########
@@ -134,7 +134,7 @@ jobs:
windows:
name: AMD64 Windows 2019 Go ${{ matrix.go }}
- runs-on: windows-latest
+ runs-on: windows-2019
Review comment:
@zeroshade is in the best position to answer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a change in pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #12425:
URL: https://github.com/apache/arrow/pull/12425#discussion_r806255892
##########
File path: .github/workflows/js.yml
##########
@@ -94,7 +94,7 @@ jobs:
windows:
name: AMD64 Windows 2019 NodeJS ${{ matrix.node }}
- runs-on: windows-latest
+ runs-on: windows-2019
Review comment:
@trxcllnt @domoritz Does JS care if running on Windows 2019 or 2022? If it doesn't we could instead just update the build name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12425:
URL: https://github.com/apache/arrow/pull/12425#issuecomment-1043063415
Benchmark runs are scheduled for baseline = 74f512260fa69903feac61e1287f6954a3d98204 and contender = d33b6a50d5a49c7cd8918644e5ea8fd50a35c052. d33b6a50d5a49c7cd8918644e5ea8fd50a35c052 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7b33e4d8929944749d78fd64bf5054fa...92e12133ca974b67a6eb871371faabdc/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/34fcb6b914b4436fae5816b099686be4...e54e5bc2c287422e9d0198f1a67a2ffb/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2f00fea949d543acae398e06ffb8787f...7bb20e92eb9a46b2ad73e6fd1ab2dde6/)
[Finished :arrow_down:0.13% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ce98c7d67ad84386b4028c02679b0d02...95de78810d2d4238b8b1ac15a5ea6129/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a change in pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #12425:
URL: https://github.com/apache/arrow/pull/12425#discussion_r806254868
##########
File path: .github/workflows/go.yml
##########
@@ -134,7 +134,7 @@ jobs:
windows:
name: AMD64 Windows 2019 Go ${{ matrix.go }}
- runs-on: windows-latest
+ runs-on: windows-2019
Review comment:
@emkornfield Does go care if running on Windows 2019 or 2022?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a change in pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #12425:
URL: https://github.com/apache/arrow/pull/12425#discussion_r806256661
##########
File path: .github/workflows/julia.yml
##########
@@ -46,7 +46,7 @@ jobs:
- 'nightly'
os:
- ubuntu-latest
- - windows-latest
+ - windows-2019
Review comment:
@quinnj Does Julia care if we run on Windows 2022 or 2019?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #12425:
URL: https://github.com/apache/arrow/pull/12425#discussion_r808059551
##########
File path: .github/workflows/cpp.yml
##########
@@ -186,9 +186,9 @@ jobs:
fail-fast: false
matrix:
os:
- - windows-latest
+ - windows-2019
include:
- - os: windows-latest
+ - os: windows-2019
Review comment:
I'd also prefer to pin the older version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12425:
URL: https://github.com/apache/arrow/pull/12425#issuecomment-1043063415
Benchmark runs are scheduled for baseline = 74f512260fa69903feac61e1287f6954a3d98204 and contender = d33b6a50d5a49c7cd8918644e5ea8fd50a35c052. d33b6a50d5a49c7cd8918644e5ea8fd50a35c052 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7b33e4d8929944749d78fd64bf5054fa...92e12133ca974b67a6eb871371faabdc/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/34fcb6b914b4436fae5816b099686be4...e54e5bc2c287422e9d0198f1a67a2ffb/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2f00fea949d543acae398e06ffb8787f...7bb20e92eb9a46b2ad73e6fd1ab2dde6/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ce98c7d67ad84386b4028c02679b0d02...95de78810d2d4238b8b1ac15a5ea6129/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a change in pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #12425:
URL: https://github.com/apache/arrow/pull/12425#discussion_r806254305
##########
File path: .github/workflows/cpp.yml
##########
@@ -186,9 +186,9 @@ jobs:
fail-fast: false
matrix:
os:
- - windows-latest
+ - windows-2019
include:
- - os: windows-latest
+ - os: windows-2019
Review comment:
@kszucs I'm pretty sure our builds fail if run on Windows 2022. They specify the 2019 generator and it can't be found. Do you want to update the generator? Or downgrade the GHA runner?
##########
File path: .github/workflows/go.yml
##########
@@ -134,7 +134,7 @@ jobs:
windows:
name: AMD64 Windows 2019 Go ${{ matrix.go }}
- runs-on: windows-latest
+ runs-on: windows-2019
Review comment:
@emkornfield Does go care if running on Windows 2019 or 2022?
##########
File path: .github/workflows/js.yml
##########
@@ -94,7 +94,7 @@ jobs:
windows:
name: AMD64 Windows 2019 NodeJS ${{ matrix.node }}
- runs-on: windows-latest
+ runs-on: windows-2019
Review comment:
@trxcllnt @domoritz Does JS care if running on Windows 2019 or 2022? If it doesn't we could instead just update the build name.
##########
File path: .github/workflows/julia.yml
##########
@@ -46,7 +46,7 @@ jobs:
- 'nightly'
os:
- ubuntu-latest
- - windows-latest
+ - windows-2019
Review comment:
@quinnj Does Julia care if we run on Windows 2022 or 2019?
##########
File path: .github/workflows/js.yml
##########
@@ -94,7 +94,7 @@ jobs:
windows:
name: AMD64 Windows 2019 NodeJS ${{ matrix.node }}
- runs-on: windows-latest
+ runs-on: windows-2019
Review comment:
Thanks, I'll leave it at `windows-latest` then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12425:
URL: https://github.com/apache/arrow/pull/12425#issuecomment-1039583034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a change in pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #12425:
URL: https://github.com/apache/arrow/pull/12425#discussion_r806254305
##########
File path: .github/workflows/cpp.yml
##########
@@ -186,9 +186,9 @@ jobs:
fail-fast: false
matrix:
os:
- - windows-latest
+ - windows-2019
include:
- - os: windows-latest
+ - os: windows-2019
Review comment:
@kszucs I'm pretty sure our builds fail if run on Windows 2022. They specify the 2019 generator and it can't be found. Do you want to update the generator? Or downgrade the GHA runner?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on a change in pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
Posted by GitBox <gi...@apache.org>.
emkornfield commented on a change in pull request #12425:
URL: https://github.com/apache/arrow/pull/12425#discussion_r806280633
##########
File path: .github/workflows/go.yml
##########
@@ -134,7 +134,7 @@ jobs:
windows:
name: AMD64 Windows 2019 Go ${{ matrix.go }}
- runs-on: windows-latest
+ runs-on: windows-2019
Review comment:
@zeroshade is in the best position to answer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12425:
URL: https://github.com/apache/arrow/pull/12425#discussion_r807100471
##########
File path: .github/workflows/cpp.yml
##########
@@ -186,9 +186,9 @@ jobs:
fail-fast: false
matrix:
os:
- - windows-latest
+ - windows-2019
include:
- - os: windows-latest
+ - os: windows-2019
Review comment:
I'd rather downgrade the GHA runner for now as an older generator is more likely to hit limitations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12425: ARROW-15682: [CI] Github starting to migrate "windows-latest" tag from windows 2019 to windows 2022
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12425:
URL: https://github.com/apache/arrow/pull/12425#issuecomment-1043055492
Since Windows C++ builds have started failing because of the migration, I'm going to merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org