You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ni...@apache.org on 2007/11/14 16:36:41 UTC
svn commit: r594917 - in
/commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines:
./ checkdigit/
Author: niallp
Date: Wed Nov 14 07:36:40 2007
New Revision: 594917
URL: http://svn.apache.org/viewvc?rev=594917&view=rev
Log:
Thread safety - make imutable values final
Modified:
commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/AbstractCalendarValidator.java
commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/AbstractFormatValidator.java
commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/AbstractNumberValidator.java
commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/ISBNValidator.java
commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/InetAddressValidator.java
commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/RegexValidator.java
commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/checkdigit/ModulusCheckDigit.java
Modified: commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/AbstractCalendarValidator.java
URL: http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/AbstractCalendarValidator.java?rev=594917&r1=594916&r2=594917&view=diff
==============================================================================
--- commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/AbstractCalendarValidator.java (original)
+++ commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/AbstractCalendarValidator.java Wed Nov 14 07:36:40 2007
@@ -35,9 +35,9 @@
*/
public abstract class AbstractCalendarValidator extends AbstractFormatValidator {
- private int dateStyle = -1;
+ private final int dateStyle;
- private int timeStyle = -1;
+ private final int timeStyle;
/**
* Construct an instance with the specified <i>strict</i>,
Modified: commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/AbstractFormatValidator.java
URL: http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/AbstractFormatValidator.java?rev=594917&r1=594916&r2=594917&view=diff
==============================================================================
--- commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/AbstractFormatValidator.java (original)
+++ commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/AbstractFormatValidator.java Wed Nov 14 07:36:40 2007
@@ -32,7 +32,7 @@
*/
public abstract class AbstractFormatValidator implements Serializable {
- private boolean strict = true;
+ private final boolean strict;
/**
* Construct an instance with the specified strict setting.
Modified: commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/AbstractNumberValidator.java
URL: http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/AbstractNumberValidator.java?rev=594917&r1=594916&r2=594917&view=diff
==============================================================================
--- commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/AbstractNumberValidator.java (original)
+++ commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/AbstractNumberValidator.java Wed Nov 14 07:36:40 2007
@@ -42,8 +42,8 @@
/** Percent <code>NumberFormat</code> type */
public static final int PERCENT_FORMAT = 2;
- private boolean allowFractions;
- private int formatType;
+ private final boolean allowFractions;
+ private final int formatType;
/**
* Construct an instance with specified <i>strict</i>
Modified: commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/ISBNValidator.java
URL: http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/ISBNValidator.java?rev=594917&r1=594916&r2=594917&view=diff
==============================================================================
--- commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/ISBNValidator.java (original)
+++ commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/ISBNValidator.java Wed Nov 14 07:36:40 2007
@@ -89,7 +89,7 @@
/** ISBN-13 Code Validator */
private CodeValidator isbn13Validator = new CodeValidator(ISBN13_REGEX, 13, EAN13CheckDigit.INSTANCE);
- private boolean convert = true;
+ private final boolean convert;
/**
* Return a singleton instance of the ISBN validator which
Modified: commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/InetAddressValidator.java
URL: http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/InetAddressValidator.java?rev=594917&r1=594916&r2=594917&view=diff
==============================================================================
--- commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/InetAddressValidator.java (original)
+++ commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/InetAddressValidator.java Wed Nov 14 07:36:40 2007
@@ -42,7 +42,7 @@
private static final InetAddressValidator VALIDATOR = new InetAddressValidator();
/** IPv4 RegexValidator */
- private RegexValidator ipv4Validator = new RegexValidator(IPV4_REGEX);
+ private final RegexValidator ipv4Validator = new RegexValidator(IPV4_REGEX);
/**
* Returns the singleton instance of this validator.
Modified: commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/RegexValidator.java
URL: http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/RegexValidator.java?rev=594917&r1=594916&r2=594917&view=diff
==============================================================================
--- commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/RegexValidator.java (original)
+++ commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/RegexValidator.java Wed Nov 14 07:36:40 2007
@@ -80,8 +80,8 @@
public final class RegexValidator implements Serializable {
private static final String MISSING_REGEX = "Regular Expression is missing";
- private Pattern pattern;
- private Pattern[] patterns;
+ private final Pattern pattern;
+ private final Pattern[] patterns;
/**
* Construct a <i>case sensitive</i> validator for a single
@@ -119,7 +119,8 @@
if (regex == null || regex.length() == 0) {
throw new IllegalArgumentException(MISSING_REGEX);
}
- pattern = Pattern.compile(regex, flags);
+ this.pattern = Pattern.compile(regex, flags);
+ this.patterns = null;
}
/**
@@ -165,6 +166,7 @@
}
patterns[i] = Pattern.compile(regexs[i], flags);
}
+ this.pattern = null;
}
/**
Modified: commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/checkdigit/ModulusCheckDigit.java
URL: http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/checkdigit/ModulusCheckDigit.java?rev=594917&r1=594916&r2=594917&view=diff
==============================================================================
--- commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/checkdigit/ModulusCheckDigit.java (original)
+++ commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/checkdigit/ModulusCheckDigit.java Wed Nov 14 07:36:40 2007
@@ -33,7 +33,7 @@
*/
public abstract class ModulusCheckDigit implements CheckDigit {
- private int modulus;
+ private final int modulus;
/**
* Construct a {@link CheckDigit} routine for a specified modulus.