[GitHub] [shardingsphere] tuichenchuxin commented on a change in pull request #12559: Fix broad cast table meta data missing.

[GitBox <gi...@apache.org>]

tuichenchuxin commented on a change in pull request #12559:
URL: https://github.com/apache/shardingsphere/pull/12559#discussion_r711594784



##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/main/java/org/apache/shardingsphere/sharding/rule/ShardingRule.java
##########
@@ -186,7 +186,6 @@ private BindingTableRule createBindingTableRule(final String bindingTableGroup)
     public Collection<String> getAllTables() {
         Collection<String> result = new HashSet<>(getTables());
         result.addAll(getAllActualTables());
-        result.addAll(broadcastTables);

Review comment:
       @strongduanmu Because I put this method into `getTables()`, So it's same.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org